You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/04 17:38:19 UTC

[GitHub] [activemq-artemis] ehossack-aws commented on a change in pull request #3564: NO-JIRA remove ordering constraint from tag in XML

ehossack-aws commented on a change in pull request #3564:
URL: https://github.com/apache/activemq-artemis/pull/3564#discussion_r625977461



##########
File path: examples/features/clustered/clustered-jgroups/src/main/resources/activemq/server1/broker.xml
##########
@@ -42,9 +42,9 @@ under the License.
 
       <broadcast-groups>
          <broadcast-group name="my-broadcast-group">
-            <broadcast-period>5000</broadcast-period>
             <jgroups-file>test-jgroups-file_ping.xml</jgroups-file>
             <jgroups-channel>active_broadcast_channel</jgroups-channel>
+            <broadcast-period>5000</broadcast-period>

Review comment:
       Will do. I was verifying the functionality works since it didn't appear there were lots of tests. 
   
   To your knowledge is there a good place for the tests to live?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org