You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/07/20 06:13:01 UTC

[isis] branch master updated: ISIS-2297: Return values should not be ignored when they contain the operation status code

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new e699df5  ISIS-2297: Return values should not be ignored when they contain the operation status code
e699df5 is described below

commit e699df56f88bd6f6ea8095f9c520f1c075c0723c
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Jul 20 08:12:41 2020 +0200

    ISIS-2297: Return values should not be ignored when they contain the
    operation status code
---
 .../isis/core/metamodel/specloader/SpecificationLoaderDefault.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoaderDefault.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoaderDefault.java
index b5140ca..14d9046 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoaderDefault.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/specloader/SpecificationLoaderDefault.java
@@ -39,6 +39,7 @@ import org.springframework.stereotype.Service;
 
 import org.apache.isis.applib.annotation.OrderPrecedence;
 import org.apache.isis.applib.services.registry.ServiceRegistry;
+import org.apache.isis.core.commons.internal.assertions._Assert;
 import org.apache.isis.core.commons.internal.base._Blackhole;
 import org.apache.isis.core.commons.internal.base._Lazy;
 import org.apache.isis.core.commons.internal.base._Timing;
@@ -411,7 +412,8 @@ public class SpecificationLoaderDefault implements SpecificationLoader {
         // validators might discover new specs 
         // to prevent deadlocks, we queue up validation requests to be processed later
         if(validationInProgress.get()) {
-            validationQueue.offer(objectSpec);
+            _Assert.assertTrue(validationQueue.offer(objectSpec), 
+                    "The Validation Queue is expected to never deadlock or grow beyond its capacity.");
             return; 
         }