You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/05/24 09:53:58 UTC

[GitHub] rymanluk commented on a change in pull request #108: nimble/ll: Vendor error event on assert

rymanluk commented on a change in pull request #108: nimble/ll: Vendor error event on assert
URL: https://github.com/apache/mynewt-nimble/pull/108#discussion_r190528646
 
 

 ##########
 File path: nimble/controller/include/controller/ble_ll.h
 ##########
 @@ -34,6 +35,14 @@ extern "C" {
 #error 32.768kHz clock required
 #endif
 
+#define BLE_LL_ASSERT(cond) \
+    if (!(cond)) { \
 
 Review comment:
   Well I had such version but then got to conclusion that it would be nice to always know if assert happens. However in order to keep current behavior I will enable it only for debug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services