You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/14 19:08:08 UTC
[GitHub] [incubator-tvm] tqchen opened a new issue #5069: [RELAY] Update the
C++ Node convention
tqchen opened a new issue #5069: [RELAY] Update the C++ Node convention
URL: https://github.com/apache/incubator-tvm/issues/5069
As of now most of the new objects we touched during refactor has been updated to follow the convention in https://github.com/apache/incubator-tvm/issues/4648. However, part of the legacy relay and tir classes are not yet updated.
This issue is to track the update process on the relay side. In particular, we need to
- Move the XXX::make API to constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5069: [RELAY]
Update the C++ Node convention
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5069: [RELAY] Update the C++ Node convention
URL: https://github.com/apache/incubator-tvm/issues/5069#issuecomment-599122582
cc @jroesch @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen closed issue #5069: [RELAY] Update the C++
Node convention
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #5069: [RELAY] Update the C++ Node convention
URL: https://github.com/apache/incubator-tvm/issues/5069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5069: [RELAY] Update the
C++ Node convention
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5069: [RELAY] Update the C++ Node convention
URL: https://github.com/apache/incubator-tvm/issues/5069#issuecomment-599122582
cc @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5069: [RELAY] Update the
C++ Node convention
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5069: [RELAY] Update the C++ Node convention
URL: https://github.com/apache/incubator-tvm/issues/5069#issuecomment-602270823
Example of the new style https://github.com/apache/incubator-tvm/blob/master/include/tvm/ir/type.h#L236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services