You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/11 13:04:02 UTC
[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
andrijapanicsb opened a new issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704
as Admin, go to the UI part that is NOT accessible for i.e. "user" role (global configuration), then logged out - you get the URL as above:
http://localhost/#/user/login?redirect=%2Fglobalsetting%3Fname%3Dpublic%26q%3Dpublic%26page%3D1%26pagesize%3D10
Then if you log in as a regular user account, you get 404:
After log out - we should NOT remember the previous position in UI - (expired/logged out or explicitly/manually logged out)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-692707485
I agree with @andrijapanicsb - it's not worth the UI errors that get thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-691857497
The problem is that if the user is on a landing page (ex: detail page). After the user logs in again if a be un-remembers URL then will be redirected to the dashboard page. This will cause the user to move some steps to get back to the correct landing page.
@rhtyd @davidjumani What do you think about this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-696075572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-691083043
if someone shares a link like that ( to the i.e. global config page, or to a specific VM/template/etc) - then we should still honour the "redirect=" part of the URL - but initially, do NOT generate that URL after a log out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-694749018
@andrijapanicsb cc @PaulAngus please review, test and close. I discussed with Andrija and we're now forgetting the path on explicit logout but not on logout due to session timeout (or mgmt server restart).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-692659423
Think it makes sense to remember the path on session timeout, not on logout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-691083043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-692647204
If that doesn't bring complexity that's OK - otherwise I prefer not to remember the path at all - as the issue of the user having to go again to the same page is very unfrequent (what @utchoang explained), though a nice improvement if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-696272787
works with latest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-692659423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-696075572
complementary to #650 , i will re-test both
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-693280722
I think it was like that before but then we got an issue reported here see https://github.com/apache/cloudstack-primate/issues/456 @PaulAngus @andrijapanicsb cc @borisstoyanov
Is David's fix to only forget redirect path on explicit logout acceptable, or now we want to revert the fix we did for #456 (that is simply forget path on session/explicit logout)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland closed issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-692620597
We may address in two ways:
(a) I think if a user explicitly logs out then we don't need to remember the last path
(b) if a user logs out due to session timeout (or mgmt server restart) then we should remember the path
What do you think @borisstoyanov @andrijapanicsb @PaulAngus @davidjumani @svenvogel ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-693280722
I think it was like that before but then we got an issue reported here see https://github.com/apache/cloudstack-primate/issues/456 @PaulAngus @andrijapanicsb cc @borisstoyanov
Is David's fix to only forget redirect path on explicit logout acceptable, or now we want to revert the fix we did for #456 (that is simply forget path on session/explicit logout)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #704:
URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-691083043
if someone shares a link like that ( to the i.e. global config page, or to a specific VM/template/etc) - then we should still honour the "redirect=" part of the URL - but initially, do NOT generate that URL after a log out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org