You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/02 02:21:17 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #13074: [pulsar-broker] Make load-balancer config dynamic for the runtime tuning

Jason918 commented on a change in pull request #13074:
URL: https://github.com/apache/pulsar/pull/13074#discussion_r760714413



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1722,6 +1723,7 @@
 
     @FieldContext(
             category = CATEGORY_LOAD_BALANCER,
+            dynamic = true,
             doc = "load balance load shedding strategy"
     )
     private String loadBalancerLoadSheddingStrategy = "org.apache.pulsar.broker.loadbalance.impl.OverloadShedder";

Review comment:
       It seems this `loadBalancerLoadSheddingStrategy` is used on broker start, dynamic won't take effect.
   Please check if all these configs are only used on broker start up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org