You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/22 23:18:00 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #28541: Speed up provider validation pre-commit

uranusjr commented on code in PR #28541:
URL: https://github.com/apache/airflow/pull/28541#discussion_r1055922836


##########
scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py:
##########
@@ -38,6 +39,9 @@
     from airflow_breeze.utils.docker_command_utils import get_extra_docker_flags
     from airflow_breeze.utils.run_utils import get_ci_image_for_pre_commits, run_command
 
+    cmd = "python3 /opt/airflow/scripts/in_container/run_provider_yaml_files_check.py"
+    if len(sys.argv) > 1:
+        cmd = cmd + " " + " ".join([shlex.quote(f) for f in sys.argv[1:]])

Review Comment:
   Better to use shlex.join



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org