You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/10/14 18:16:00 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8371: [migration] make names non-nullable

codecov-io commented on issue #8371: [migration] make names non-nullable
URL: https://github.com/apache/incubator-superset/pull/8371#issuecomment-541835842
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=h1) Report
   > Merging [#8371](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2117d1ef9d0ce041d91a75eba47d0b07dabed8c9?src=pr&el=desc) will **decrease** coverage by `7.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8371/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8371      +/-   ##
   ==========================================
   - Coverage   67.57%   60.55%   -7.03%     
   ==========================================
     Files         448      332     -116     
     Lines       22527    10254   -12273     
     Branches     2364     2364              
   ==========================================
   - Hits        15222     6209    -9013     
   + Misses       7167     3907    -3260     
     Partials      138      138
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
   | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | | |
   | [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | | |
   | [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | | |
   | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | | |
   | [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
   | [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | | |
   | ... and [103 more](https://codecov.io/gh/apache/incubator-superset/pull/8371/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=footer). Last update [2117d1e...ce0b8cf](https://codecov.io/gh/apache/incubator-superset/pull/8371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org