You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-commits@perl.apache.org by st...@apache.org on 2015/03/17 19:19:06 UTC

svn commit: r1667369 - /perl/Apache-Test/trunk/Makefile.PL

Author: stevehay
Date: Tue Mar 17 18:19:05 2015
New Revision: 1667369

URL: http://svn.apache.org/r1667369
Log:
Apache-Test's Makefile.PL checks for dependencies in a non-deterministic
order, due to hash randomisation.  The resulting non-deterministic trace
output causes noise when diffing build logs.  Attached patch makes it
deterministic.

Patch by Zefram <ze...@fysh.org> from rt.cpan.org #102829.

Modified:
    perl/Apache-Test/trunk/Makefile.PL

Modified: perl/Apache-Test/trunk/Makefile.PL
URL: http://svn.apache.org/viewvc/perl/Apache-Test/trunk/Makefile.PL?rev=1667369&r1=1667368&r2=1667369&view=diff
==============================================================================
--- perl/Apache-Test/trunk/Makefile.PL (original)
+++ perl/Apache-Test/trunk/Makefile.PL Tue Mar 17 18:19:05 2015
@@ -98,14 +98,14 @@ check_prereqs();
 
 sub check_prereqs {
     my %fail = ();
-    for (keys %prereq) {
+    for (sort keys %prereq) {
         unless (chk_version($_, $prereq{$_})) {
             $fail{$_} = $prereq{$_};
         }
     }
     if (%fail) {
         error "\nThe following Apache-Test dependencies aren't satisfied:",
-            map { "\t$_: $fail{$_}" } keys %fail;
+            map { "\t$_: $fail{$_}" } sort keys %fail;
         error "Install those from http://search.cpan.org and try again";
         exit 0;
     }