You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 04:48:47 UTC
[GitHub] [incubator-superset] junlincc removed a comment on pull request #11808: feat: add title to dashboard tabbed panel
junlincc removed a comment on pull request #11808:
URL: https://github.com/apache/incubator-superset/pull/11808#issuecomment-741523244
> 1. this PR is relevant to the Native Filter project for the reason that filter Scope show tabbed panel and those panel don't have names:
> 
based on @graceguo-supercat 's comment, adding tab name is not gonna help tab level filter scoping, this is also not in scope of the filter p1. Grace, do you mind guiding us to the right direction to solve this problem?
> 2. _extra padding value around charts_ is taken from the original design and also requested by one of our clients
> so maybe we can think about reducing the extra padding
I just pulled the PR, it does create some overlapping and alignment issues. I understand your organization's need and I'm not opposed to adding some padding between charts but please address Grace's concern -re-calculate width for each chart.
also, if you can provide the design or screenshot in advance so our designer @mihir174 can provide feedback before implementing.
<img width="1723" alt="Screen Shot 2020-12-08 at 8 31 45 PM" src="https://user-images.githubusercontent.com/67837651/101585833-6f96db80-3995-11eb-8a8e-7470b7182d12.png">
<img width="314" alt="Screen Shot 2020-12-08 at 8 38 26 PM" src="https://user-images.githubusercontent.com/67837651/101585810-63128300-3995-11eb-9105-78bebdd30813.png">
let's make it work for all of us. thanks! @amitmiran137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org