You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ec...@apache.org on 2010/04/13 21:43:47 UTC
svn commit: r933766 -
/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
Author: eckardjf
Date: Tue Apr 13 19:43:46 2010
New Revision: 933766
URL: http://svn.apache.org/viewvc?rev=933766&view=rev
Log:
allow bypassing the additional party step of purchase order entry when finalizeReqAdditionalParty=false
Modified:
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=933766&r1=933765&r2=933766&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java Tue Apr 13 19:43:46 2010
@@ -979,7 +979,6 @@ public class CheckOutEvents {
if (cart.getOrderType().equals("PURCHASE_ORDER")) {
// Force checks for the following
requireCustomer = true; requireShipping = true; requireOptions = true;
- requireAdditionalParty = true;
processOrder = new String[] {"customer", "term", "shipping", "shipGroups", "options", "payment",
"addparty", "paysplit"};
}
Re: svn commit: r933766 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Ah okay thanks Joe, I had missed the line which was checking the request attribute and only saw this one:
boolean requireAdditionalParty = isAnonymousCheckout;
Regards
Scott
On 15/04/2010, at 2:49 AM, Joe Eckard wrote:
> When creating a sales order, you could pass the request parameter "finalizeReqAdditionalParty=false" to routeOrderEntry and skip the "add party" screen. You couldn't do this when creating a purchase order.
>
> This does not change the default behavior, which is to show the "add party" screen as the last step - you have to explicitly say you want to skip it.
>
> True, using "mode=addpty" will let you skip that screen also (by setting a cart attribute), but that is used on the add party screen itself, when actually adding a party. Also, "finalizeReqAdditionalParty=false" sees to clearly convey the desired behavior as opposed to "mode=addpty".
>
>
> On Apr 13, 2010, at 5:19 PM, Scott Gray wrote:
>
>> Hi Joe,
>>
>> It looks like you've just changed a default that could already be overridden by setting an attribute on the cart. Could you explain a little more?
>>
>> Thanks
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 14/04/2010, at 7:43 AM, eckardjf@apache.org wrote:
>>
>>> Author: eckardjf
>>> Date: Tue Apr 13 19:43:46 2010
>>> New Revision: 933766
>>>
>>> URL: http://svn.apache.org/viewvc?rev=933766&view=rev
>>> Log:
>>> allow bypassing the additional party step of purchase order entry when finalizeReqAdditionalParty=false
>>>
>>> Modified:
>>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>>>
>>> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=933766&r1=933765&r2=933766&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (original)
>>> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java Tue Apr 13 19:43:46 2010
>>> @@ -979,7 +979,6 @@ public class CheckOutEvents {
>>> if (cart.getOrderType().equals("PURCHASE_ORDER")) {
>>> // Force checks for the following
>>> requireCustomer = true; requireShipping = true; requireOptions = true;
>>> - requireAdditionalParty = true;
>>> processOrder = new String[] {"customer", "term", "shipping", "shipGroups", "options", "payment",
>>> "addparty", "paysplit"};
>>> }
>>>
>>>
>>
>
Re: svn commit: r933766 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
Posted by Joe Eckard <jo...@redrocketcorp.com>.
When creating a sales order, you could pass the request parameter
"finalizeReqAdditionalParty=false" to routeOrderEntry and skip the
"add party" screen. You couldn't do this when creating a purchase order.
This does not change the default behavior, which is to show the "add
party" screen as the last step - you have to explicitly say you want
to skip it.
True, using "mode=addpty" will let you skip that screen also (by
setting a cart attribute), but that is used on the add party screen
itself, when actually adding a party. Also,
"finalizeReqAdditionalParty=false" sees to clearly convey the desired
behavior as opposed to "mode=addpty".
On Apr 13, 2010, at 5:19 PM, Scott Gray wrote:
> Hi Joe,
>
> It looks like you've just changed a default that could already be
> overridden by setting an attribute on the cart. Could you explain a
> little more?
>
> Thanks
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 14/04/2010, at 7:43 AM, eckardjf@apache.org wrote:
>
>> Author: eckardjf
>> Date: Tue Apr 13 19:43:46 2010
>> New Revision: 933766
>>
>> URL: http://svn.apache.org/viewvc?rev=933766&view=rev
>> Log:
>> allow bypassing the additional party step of purchase order entry
>> when finalizeReqAdditionalParty=false
>>
>> Modified:
>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/
>> CheckOutEvents.java
>>
>> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/
>> shoppingcart/CheckOutEvents.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=933766&r1=933765&r2=933766&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/
>> CheckOutEvents.java (original)
>> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/
>> CheckOutEvents.java Tue Apr 13 19:43:46 2010
>> @@ -979,7 +979,6 @@ public class CheckOutEvents {
>> if (cart.getOrderType().equals("PURCHASE_ORDER")) {
>> // Force checks for the following
>> requireCustomer = true; requireShipping = true;
>> requireOptions = true;
>> - requireAdditionalParty = true;
>> processOrder = new String[] {"customer", "term",
>> "shipping", "shipGroups", "options", "payment",
>> "addparty", "paysplit"};
>> }
>>
>>
>
Re: svn commit: r933766 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
Posted by Scott Gray <sc...@hotwaxmedia.com>.
Hi Joe,
It looks like you've just changed a default that could already be overridden by setting an attribute on the cart. Could you explain a little more?
Thanks
Scott
HotWax Media
http://www.hotwaxmedia.com
On 14/04/2010, at 7:43 AM, eckardjf@apache.org wrote:
> Author: eckardjf
> Date: Tue Apr 13 19:43:46 2010
> New Revision: 933766
>
> URL: http://svn.apache.org/viewvc?rev=933766&view=rev
> Log:
> allow bypassing the additional party step of purchase order entry when finalizeReqAdditionalParty=false
>
> Modified:
> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
>
> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=933766&r1=933765&r2=933766&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java (original)
> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java Tue Apr 13 19:43:46 2010
> @@ -979,7 +979,6 @@ public class CheckOutEvents {
> if (cart.getOrderType().equals("PURCHASE_ORDER")) {
> // Force checks for the following
> requireCustomer = true; requireShipping = true; requireOptions = true;
> - requireAdditionalParty = true;
> processOrder = new String[] {"customer", "term", "shipping", "shipGroups", "options", "payment",
> "addparty", "paysplit"};
> }
>
>