You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by lu...@apache.org on 2015/07/21 00:02:55 UTC
svn commit: r1692030 -
/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
Author: lucastheisen
Date: Mon Jul 20 22:02:54 2015
New Revision: 1692030
URL: http://svn.apache.org/r1692030
Log:
Fixed MemoryClearingBuffer so that it does not clear out originalChars
Modified:
directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java?rev=1692030&r1=1692029&r2=1692030&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java (original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java Mon Jul 20 22:02:54 2015
@@ -158,8 +158,9 @@ public final class MemoryClearingBuffer
{
Arrays.fill( computedChars, '0' );
}
- if ( precomputedChars != null )
+ if ( precomputedChars != null && precomputedChars != this.originalChars )
{
+ // only nullify if NOT originalChars
Arrays.fill( precomputedChars, '0' );
}