[GitHub] [dubbo] chickenlj commented on a diff in pull request #12472: Check reference after register

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #12472:
URL: https://github.com/apache/dubbo/pull/12472#discussion_r1221150094


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java:
##########
@@ -631,8 +650,22 @@ private void createInvoker() {
         }
     }
 
-    private void checkInvokerAvailable() throws IllegalStateException {
-        if (shouldCheck() && !invoker.isAvailable()) {
+    private void checkInvokerAvailable(long timeout) throws IllegalStateException {
+        if (!shouldCheck()) {
+            return;
+        }
+        boolean available = invoker.isAvailable();
+        long checkDeadline = System.currentTimeMillis() + timeout;

Review Comment:
   Better print something here informing users the process is waiting for address notification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org