You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/11/25 22:55:55 UTC
[GitHub] [incubator-pinot] kkrugler opened a new issue #6293: Fix creation of pinot-integration-tests jar
kkrugler opened a new issue #6293:
URL: https://github.com/apache/incubator-pinot/issues/6293
Currently the `pinot-integration-tests` jar is empty (other than a manifest), versus containing the very useful `BaseClusterIntegrationTest` class and related code. The issue is that it should be being build as a tests jar, using code from the `src/test/` directory.
In addition, it would be good to make it a fully shaded jar, so that its dependencies on other jars (for example, ZooKeeper) don't cause jar hell with project code that is using this code for integration testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kkrugler commented on issue #6293: Fix creation of pinot-integration-tests jar
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #6293:
URL: https://github.com/apache/incubator-pinot/issues/6293#issuecomment-794537123
On Slack I'd asked:
> I’m wondering if it would work better to have a separate Pinot sub-project/jar that can be used to spin up a stand-alone “mini” Pinot cluster, and have that jar be used by pinot-integration-tests (and 3rd parties wanting to do the same). This would provide cleaner separation for what’s used internally by Pinot, versus what projects using Pinot would need to use.
@kishoreg responded with:
> \+100 for this
> this is the right thing to do
> in fact our quickstart is very similar to this
> it just brings up everything in one process
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kkrugler commented on issue #6293: Fix creation of pinot-integration-tests jar
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #6293:
URL: https://github.com/apache/incubator-pinot/issues/6293#issuecomment-766418350
See a somewhat related issue filed for Flink - [Move test base classes from flink-tests to flink-test-utils](https://issues.apache.org/jira/browse/FLINK-21107)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kkrugler commented on issue #6293: Fix creation of pinot-integration-tests jar
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #6293:
URL: https://github.com/apache/incubator-pinot/issues/6293#issuecomment-766418350
See a somewhat related issue filed for Flink - [Move test base classes from flink-tests to flink-test-utils](https://issues.apache.org/jira/browse/FLINK-21107)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org