You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/15 18:22:53 UTC
[GitHub] [camel] ThePrez opened a new pull request #5216: [MINOR] password parsing bugfix in jt400 component
ThePrez opened a new pull request #5216:
URL: https://github.com/apache/camel/pull/5216
Current username/password parsing in the jt400 has two very minor bugs. Both should be fixed with a simple one-line change.
**Bug 1: using an empty password results in an exception**
An empty password is allowed when the username is `*CURRENT`. However, specifying `*CURRENT:` as the `uid:pwd` string results in an exception
```pascal
Caused by: java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 1
at org.apache.camel.component.jt400.Jt400Configuration.<init> (Jt400Configuration.java:130)
at org.apache.camel.component.jt400.Jt400Endpoint.<init> (Jt400Endpoint.java:68)
at org.apache.camel.component.jt400.Jt400Component.createEndpoint (Jt400Component.java:77)
at org.apache.camel.support.DefaultComponent.createEndpoint (DefaultComponent.java:237)
at org.apache.camel.impl.engine.AbstractCamelContext.doGetEndpoint (AbstractCamelContext.java:846)
at org.apache.camel.impl.engine.AbstractCamelContext.getEndpoint (AbstractCamelContext.java:768)
at org.apache.camel.support.CamelContextHelper.resolveEndpoint (CamelContextHelper.java:123)
```
**Bug 2: passwords are allowed to have colons**
If my password has a colon (for instance, `pass:word`), then it is not parsed properly. It will parse the password as just `pass` rather than the full `pass:word`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5216: [MINOR] password parsing bugfix in jt400 component
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5216:
URL: https://github.com/apache/camel/pull/5216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5216: [MINOR] password parsing bugfix in jt400 component
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5216:
URL: https://github.com/apache/camel/pull/5216#issuecomment-799671466
Use RAW() syntax for password with special characters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ThePrez commented on pull request #5216: [MINOR] password parsing bugfix in jt400 component
Posted by GitBox <gi...@apache.org>.
ThePrez commented on pull request #5216:
URL: https://github.com/apache/camel/pull/5216#issuecomment-799732701
>
>
> Use RAW() syntax for password with special characters
Ahh, sorry for missing that in [the docs](https://camel.apache.org/manual/latest/faq/how-do-i-configure-endpoints.html#HowdoIconfigureendpoints-Configuringparametervaluesusingrawvalues)! Fix should still address the empty-password scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org