You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by Attila Doroszlai <ad...@apache.org> on 2020/01/06 20:41:03 UTC
[DISCUSS] get clean CI run in fork before opening PR
Hi All,
Ozone CI checks are run via Github Actions for both commits and PRs.
They are even run in forks. This gives us the chance to get early
feedback from CI before opening a PR by following these steps (only
steps 2-3 are new):
1. push to branch in fork
2. wait for CI checks to complete
3. fix any errors
4. open PR
In other words: please make sure to get a clean CI run in fork before
opening PR.
This has the following benefits:
* minimize Github Actions resource usage from Ozone's quota
(https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits)
* improve reviewer bandwidth
Please consider the suggestion, and follow this approach if you agree.
thanks,
Attila
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by Shashikant Banerjee <sb...@cloudera.com.INVALID>.
+1
Thanks
Shashi
On Tue, Jan 7, 2020 at 10:33 AM Dinesh Chitlangia <di...@gmail.com>
wrote:
> +1
>
> Thanks,
> Dinesh
>
> On Mon, Jan 6, 2020 at 4:08 PM yisheng lian <li...@gmail.com> wrote:
>
> > Great idea +1
> >
> > Thanks Attila for this suggestion.
> >
> >
> > Anu Engineer <ae...@apache.org> 於 2020年1月7日 週二 上午4:48寫道：
> >
> > > I think this is a great idea. Especially since it conserves the Ozone's
> > > Github Action minutes.
> > >
> > > Thanks
> > > Anu
> > >
> > >
> > > On Mon, Jan 6, 2020 at 12:41 PM Attila Doroszlai <
> adoroszlai@apache.org>
> > > wrote:
> > >
> > > > Hi All,
> > > >
> > > > Ozone CI checks are run via Github Actions for both commits and PRs.
> > > > They are even run in forks. This gives us the chance to get early
> > > > feedback from CI before opening a PR by following these steps (only
> > > > steps 2-3 are new):
> > > >
> > > > 1. push to branch in fork
> > > > 2. wait for CI checks to complete
> > > > 3. fix any errors
> > > > 4. open PR
> > > >
> > > > In other words: please make sure to get a clean CI run in fork before
> > > > opening PR.
> > > >
> > > > This has the following benefits:
> > > >
> > > > * minimize Github Actions resource usage from Ozone's quota
> > > > (
> > > >
> > >
> >
> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits
> > > > )
> > > >
> > > > * improve reviewer bandwidth
> > > >
> > > > Please consider the suggestion, and follow this approach if you
> agree.
> > > >
> > > > thanks,
> > > > Attila
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
> > > >
> > > >
> > >
> >
> >
> > --
> > 連奕盛
> > lianp964@gmail.com
> > Phone:0901282616
> >
>
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by Dinesh Chitlangia <di...@gmail.com>.
+1
Thanks,
Dinesh
On Mon, Jan 6, 2020 at 4:08 PM yisheng lian <li...@gmail.com> wrote:
> Great idea +1
>
> Thanks Attila for this suggestion.
>
>
> Anu Engineer <ae...@apache.org> 於 2020年1月7日 週二 上午4:48寫道：
>
> > I think this is a great idea. Especially since it conserves the Ozone's
> > Github Action minutes.
> >
> > Thanks
> > Anu
> >
> >
> > On Mon, Jan 6, 2020 at 12:41 PM Attila Doroszlai <ad...@apache.org>
> > wrote:
> >
> > > Hi All,
> > >
> > > Ozone CI checks are run via Github Actions for both commits and PRs.
> > > They are even run in forks. This gives us the chance to get early
> > > feedback from CI before opening a PR by following these steps (only
> > > steps 2-3 are new):
> > >
> > > 1. push to branch in fork
> > > 2. wait for CI checks to complete
> > > 3. fix any errors
> > > 4. open PR
> > >
> > > In other words: please make sure to get a clean CI run in fork before
> > > opening PR.
> > >
> > > This has the following benefits:
> > >
> > > * minimize Github Actions resource usage from Ozone's quota
> > > (
> > >
> >
> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits
> > > )
> > >
> > > * improve reviewer bandwidth
> > >
> > > Please consider the suggestion, and follow this approach if you agree.
> > >
> > > thanks,
> > > Attila
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
> > >
> > >
> >
>
>
> --
> 連奕盛
> lianp964@gmail.com
> Phone:0901282616
>
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by yisheng lian <li...@gmail.com>.
Great idea +1
Thanks Attila for this suggestion.
Anu Engineer <ae...@apache.org> 於 2020年1月7日 週二 上午4:48寫道：
> I think this is a great idea. Especially since it conserves the Ozone's
> Github Action minutes.
>
> Thanks
> Anu
>
>
> On Mon, Jan 6, 2020 at 12:41 PM Attila Doroszlai <ad...@apache.org>
> wrote:
>
> > Hi All,
> >
> > Ozone CI checks are run via Github Actions for both commits and PRs.
> > They are even run in forks. This gives us the chance to get early
> > feedback from CI before opening a PR by following these steps (only
> > steps 2-3 are new):
> >
> > 1. push to branch in fork
> > 2. wait for CI checks to complete
> > 3. fix any errors
> > 4. open PR
> >
> > In other words: please make sure to get a clean CI run in fork before
> > opening PR.
> >
> > This has the following benefits:
> >
> > * minimize Github Actions resource usage from Ozone's quota
> > (
> >
> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits
> > )
> >
> > * improve reviewer bandwidth
> >
> > Please consider the suggestion, and follow this approach if you agree.
> >
> > thanks,
> > Attila
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
> >
> >
>
--
連奕盛
lianp964@gmail.com
Phone:0901282616
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by Anu Engineer <ae...@apache.org>.
I think this is a great idea. Especially since it conserves the Ozone's
Github Action minutes.
Thanks
Anu
On Mon, Jan 6, 2020 at 12:41 PM Attila Doroszlai <ad...@apache.org>
wrote:
> Hi All,
>
> Ozone CI checks are run via Github Actions for both commits and PRs.
> They are even run in forks. This gives us the chance to get early
> feedback from CI before opening a PR by following these steps (only
> steps 2-3 are new):
>
> 1. push to branch in fork
> 2. wait for CI checks to complete
> 3. fix any errors
> 4. open PR
>
> In other words: please make sure to get a clean CI run in fork before
> opening PR.
>
> This has the following benefits:
>
> * minimize Github Actions resource usage from Ozone's quota
> (
> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits
> )
>
> * improve reviewer bandwidth
>
> Please consider the suggestion, and follow this approach if you agree.
>
> thanks,
> Attila
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by Aravindan Vijayan <av...@cloudera.com.INVALID>.
+1
On Tue, Jun 23, 2020 at 10:16 PM Arpit Agarwal
<aa...@cloudera.com.invalid> wrote:
> +1
>
>
> > On Jan 6, 2020, at 12:41 PM, Attila Doroszlai <ad...@apache.org>
> wrote:
> >
> > Hi All,
> >
> > Ozone CI checks are run via Github Actions for both commits and PRs.
> > They are even run in forks. This gives us the chance to get early
> > feedback from CI before opening a PR by following these steps (only
> > steps 2-3 are new):
> >
> > 1. push to branch in fork
> > 2. wait for CI checks to complete
> > 3. fix any errors
> > 4. open PR
> >
> > In other words: please make sure to get a clean CI run in fork before
> > opening PR.
> >
> > This has the following benefits:
> >
> > * minimize Github Actions resource usage from Ozone's quota
> > (
> https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits
> )
> >
> > * improve reviewer bandwidth
> >
> > Please consider the suggestion, and follow this approach if you agree.
> >
> > thanks,
> > Attila
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
>
>
--
Thanks & Regards,
Aravindan
Re: [DISCUSS] get clean CI run in fork before opening PR
Posted by Arpit Agarwal <aa...@cloudera.com.INVALID>.
+1
> On Jan 6, 2020, at 12:41 PM, Attila Doroszlai <ad...@apache.org> wrote:
>
> Hi All,
>
> Ozone CI checks are run via Github Actions for both commits and PRs.
> They are even run in forks. This gives us the chance to get early
> feedback from CI before opening a PR by following these steps (only
> steps 2-3 are new):
>
> 1. push to branch in fork
> 2. wait for CI checks to complete
> 3. fix any errors
> 4. open PR
>
> In other words: please make sure to get a clean CI run in fork before
> opening PR.
>
> This has the following benefits:
>
> * minimize Github Actions resource usage from Ozone's quota
> (https://help.github.com/en/actions/automating-your-workflow-with-github-actions/about-github-actions#usage-limits)
>
> * improve reviewer bandwidth
>
> Please consider the suggestion, and follow this approach if you agree.
>
> thanks,
> Attila
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: ozone-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-dev-help@hadoop.apache.org