[GitHub] [hive] okumin commented on a diff in pull request #4346: HIVE-26832: Implement SHOW PARTITIONS for Iceberg Tables

["okumin (via GitHub)" <gi...@apache.org>]

okumin commented on code in PR #4346:
URL: https://github.com/apache/hive/pull/4346#discussion_r1200413022


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionsOperation.java:
##########
@@ -54,12 +55,17 @@ public ShowPartitionsOperation(DDLOperationContext context, ShowPartitionsDesc d
   @Override
   public int execute() throws HiveException {
     Table tbl = context.getDb().getTable(desc.getTabName());
-    if (!tbl.isPartitioned()) {
-      throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED, desc.getTabName());
+    boolean isIcebergTable = isIcebergTable(tbl);
+    if (!(tbl.isPartitioned() || isIcebergTable)) {
+        throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED, desc.getTabName());

Review Comment:
   Can we generalize this part rather than hardcoding ICEBERG? I guess this is useful for another storage handler.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org