You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/04/14 17:34:29 UTC

Review Request 20318: Use appropriate packages for components on ubuntu

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5460
    https://issues.apache.org/jira/browse/AMBARI-5460


Repository: ambari


Description
-------


Diffs
-----

  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
  ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 

Diff: https://reviews.apache.org/r/20318/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 20318: Use appropriate packages for components on ubuntu

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/
-----------------------------------------------------------

(Updated April 14, 2014, 3:48 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5460
    https://issues.apache.org/jira/browse/AMBARI-5460


Repository: ambari


Description (updated)
-------

snappy -> libsnappy1
snappy-devel -> libsnappy-dev
lzo, hadoop-lzo-native -> liblzo2-2
hadoop-libhdfs -> libhdfs0 , libhdfs0-dev, hadoop-hdfs
extjs-2.2-1 -> extjs


Diffs (updated)
-----

  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
  ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
  ambari-agent/src/test/python/resource_management/TestPackageResource.py 02aa3fb 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 
  ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 09d77d4 

Diff: https://reviews.apache.org/r/20318/diff/


Testing (updated)
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 20318: Use appropriate packages for components on ubuntu

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/#review40261
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On April 14, 2014, 3:49 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20318/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 3:49 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5460
>     https://issues.apache.org/jira/browse/AMBARI-5460
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> snappy -> libsnappy1
> snappy-devel -> libsnappy-dev
> lzo, hadoop-lzo-native -> liblzo2-2
> hadoop-libhdfs -> libhdfs0 , libhdfs0-dev, hadoop-hdfs
> extjs-2.2-1 -> extjs
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
>   ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 02aa3fb 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 09d77d4 
> 
> Diff: https://reviews.apache.org/r/20318/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 20318: Use appropriate packages for components on ubuntu

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On April 14, 2014, 3:57 p.m., Dmitro Lisnichenko wrote:
> > ambari-agent/src/main/python/resource_management/core/providers/package/apt.py, line 26
> > <https://reviews.apache.org/r/20318/diff/2/?file=556096#file556096line26>
> >
> >     I think it's a bad idea to use "--force-yes" since documentation states that "This is a dangerous option that will cause apt to continue without prompting if it is doing something potentially harmful. It           should not be used except in very special situations. Using force-yes can potentially destroy your system!"

I'll create ticket for this thing, so we will fix that before release. This is just temporary to do testing on vms


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/#review40259
-----------------------------------------------------------


On April 14, 2014, 3:49 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20318/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 3:49 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5460
>     https://issues.apache.org/jira/browse/AMBARI-5460
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> snappy -> libsnappy1
> snappy-devel -> libsnappy-dev
> lzo, hadoop-lzo-native -> liblzo2-2
> hadoop-libhdfs -> libhdfs0 , libhdfs0-dev, hadoop-hdfs
> extjs-2.2-1 -> extjs
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
>   ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 02aa3fb 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 09d77d4 
> 
> Diff: https://reviews.apache.org/r/20318/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 20318: Use appropriate packages for components on ubuntu

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/#review40259
-----------------------------------------------------------



ambari-agent/src/main/python/resource_management/core/providers/package/apt.py
<https://reviews.apache.org/r/20318/#comment73209>

    I think it's a bad idea to use "--force-yes" since documentation states that "This is a dangerous option that will cause apt to continue without prompting if it is doing something potentially harmful. It           should not be used except in very special situations. Using force-yes can potentially destroy your system!"


- Dmitro Lisnichenko


On April 14, 2014, 3:49 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20318/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 3:49 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5460
>     https://issues.apache.org/jira/browse/AMBARI-5460
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> snappy -> libsnappy1
> snappy-devel -> libsnappy-dev
> lzo, hadoop-lzo-native -> liblzo2-2
> hadoop-libhdfs -> libhdfs0 , libhdfs0-dev, hadoop-hdfs
> extjs-2.2-1 -> extjs
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
>   ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 02aa3fb 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 09d77d4 
> 
> Diff: https://reviews.apache.org/r/20318/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 20318: Use appropriate packages for components on ubuntu

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20318/
-----------------------------------------------------------

(Updated April 14, 2014, 3:49 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5460
    https://issues.apache.org/jira/browse/AMBARI-5460


Repository: ambari


Description
-------

snappy -> libsnappy1
snappy-devel -> libsnappy-dev
lzo, hadoop-lzo-native -> liblzo2-2
hadoop-libhdfs -> libhdfs0 , libhdfs0-dev, hadoop-hdfs
extjs-2.2-1 -> extjs


Diffs
-----

  ambari-agent/src/main/python/resource_management/core/providers/package/apt.py 8d53f96 
  ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 1c5598b 
  ambari-agent/src/test/python/resource_management/TestPackageResource.py 02aa3fb 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py 4e51c17 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py c76c028 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/metainfo.xml 349f810 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml d6ef639 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml ab6dc7b 
  ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 09d77d4 

Diff: https://reviews.apache.org/r/20318/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk