You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Philip Martin <ph...@wandisco.com> on 2010/03/12 19:15:27 UTC
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in /subversion/trunk/subversion: libsvn_client/cleanup.c tests/cmdline/upgrade_tests.py tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Daniel Näslund <da...@longitudo.com> writes:
> Can this be committed?
>
> [[[
> Follow up to r920118.
>
> * subversion/libsvn_client/cleanup.c
> (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> casts. Use a more descriptive variable name for the path holding the
> svn:externals declaration.
> Suggested by: philipm
> julianfoad
> ]]]
Yes.
--
Philip
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in
/subversion/trunk/subversion: libsvn_client/cleanup.c
tests/cmdline/upgrade_tests.py
tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Posted by Julian Foad <ju...@wandisco.com>.
On Fri, 2010-03-12, Daniel Näslund wrote:
> On Fri, Mar 12, 2010 at 06:15:27PM +0000, Philip Martin wrote:
> > Daniel Näslund <da...@longitudo.com> writes:
> >
> > > Can this be committed?
> > >
> > > [[[
> > > Follow up to r920118.
> > >
> > > * subversion/libsvn_client/cleanup.c
> > > (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> > > casts. Use a more descriptive variable name for the path holding the
> > > svn:externals declaration.
> > > Suggested by: philipm
> > > julianfoad
> > > ]]]
> >
> > Yes.
>
> Commited in r922387.
Thanks!
- Julian
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in
/subversion/trunk/subversion: libsvn_client/cleanup.c
tests/cmdline/upgrade_tests.py
tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Posted by Julian Foad <ju...@wandisco.com>.
On Fri, 2010-03-12, Daniel Näslund wrote:
> On Fri, Mar 12, 2010 at 06:15:27PM +0000, Philip Martin wrote:
> > Daniel Näslund <da...@longitudo.com> writes:
> >
> > > Can this be committed?
> > >
> > > [[[
> > > Follow up to r920118.
> > >
> > > * subversion/libsvn_client/cleanup.c
> > > (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> > > casts. Use a more descriptive variable name for the path holding the
> > > svn:externals declaration.
> > > Suggested by: philipm
> > > julianfoad
> > > ]]]
> >
> > Yes.
>
> Commited in r922387.
Thanks!
- Julian
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in
/subversion/trunk/subversion: libsvn_client/cleanup.c
tests/cmdline/upgrade_tests.py
tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Posted by Daniel Näslund <da...@longitudo.com>.
On Fri, Mar 12, 2010 at 06:15:27PM +0000, Philip Martin wrote:
> Daniel Näslund <da...@longitudo.com> writes:
>
> > Can this be committed?
> >
> > [[[
> > Follow up to r920118.
> >
> > * subversion/libsvn_client/cleanup.c
> > (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> > casts. Use a more descriptive variable name for the path holding the
> > svn:externals declaration.
> > Suggested by: philipm
> > julianfoad
> > ]]]
>
> Yes.
Commited in r922387.
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in
/subversion/trunk/subversion: libsvn_client/cleanup.c
tests/cmdline/upgrade_tests.py
tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Posted by Daniel Näslund <da...@longitudo.com>.
On Fri, Mar 12, 2010 at 06:15:27PM +0000, Philip Martin wrote:
> Daniel Näslund <da...@longitudo.com> writes:
>
> > Can this be committed?
> >
> > [[[
> > Follow up to r920118.
> >
> > * subversion/libsvn_client/cleanup.c
> > (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> > casts. Use a more descriptive variable name for the path holding the
> > svn:externals declaration.
> > Suggested by: philipm
> > julianfoad
> > ]]]
>
> Yes.
Commited in r922387.
Re: [PATCH] Follow-up to r920118. was:Re: svn commit: r920118 - in
/subversion/trunk/subversion: libsvn_client/cleanup.c
tests/cmdline/upgrade_tests.py
tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
Posted by Daniel Näslund <da...@longitudo.com>.
On Fri, Mar 12, 2010 at 06:15:27PM +0000, Philip Martin wrote:
> Daniel Näslund <da...@longitudo.com> writes:
>
> > Can this be committed?
> >
> > [[[
> > Follow up to r920118.
> >
> > * subversion/libsvn_client/cleanup.c
> > (svn_client_upgrade): Use svn__apr_hash_index_{key,val} to avoid
> > casts. Use a more descriptive variable name for the path holding the
> > svn:externals declaration.
> > Suggested by: philipm
> > julianfoad
> > ]]]
>
> Yes.
Commited in r922387.