You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <de...@db.apache.org> on 2006/04/05 23:24:43 UTC

[jira] Created: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
--------------------------------------------------------------------------------------

         Key: DERBY-1184
         URL: http://issues.apache.org/jira/browse/DERBY-1184
     Project: Derby
        Type: Bug

  Components: JDBC  
    Versions: 10.2.0.0    
 Environment: Derby network client
    Reporter: Kristian Waagan
    Priority: Minor


The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Bryan Pendleton reassigned DERBY-1184:
--------------------------------------

    Assign To: Bryan Pendleton

Thanks for contributing the patch, Kristian. I will see if there is a simple way for me to add a test for this change; I think I can see a way to do it.

Unless there are any other comments on this issue, I'll commit this change once I get the test in place.


> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1184?page=comments#action_12373590 ] 

Kristian Waagan commented on DERBY-1184:
----------------------------------------

derbyall run without failures (Solaris10, Java 1.5, 646 tests run).

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1184?page=comments#action_12373438 ] 

Bryan Pendleton commented on DERBY-1184:
----------------------------------------

This looks like a nice clean change, but shouldn't we add a test? Unless you find during your derbyall run that there already is a test, that is.

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]
     
Kristian Waagan closed DERBY-1184:
----------------------------------


Confirmed that the test passes (DerbyNetClient only). Thanks for writing the test and fixing the problem Bryan!

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Kristian Waagan reassigned DERBY-1184:
--------------------------------------

    Assign To:     (was: Kristian Waagan)

I won't be working more on this for a long time... A test is missing, please add it ;)

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Kristian Waagan updated DERBY-1184:
-----------------------------------

    Derby Info: [Patch Available]

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Bryan Pendleton updated DERBY-1184:
-----------------------------------

    Attachment: derby_1184_with_test.diff

Here's my proposal for a regression test. Attached file 'derby_1184_with_test.diff' is an updated patch file which includes Kristian's original change to CallableStatement.java and also includes a change to derbynet/callable.java to add a simple regression test.


> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1184?page=comments#action_12373651 ] 

Bryan Pendleton commented on DERBY-1184:
----------------------------------------

Thanks for the good eyes, Kristian!

I confirmed your finding, updated the test, and committed the changed test to subversion as revision 392313.

Can you re-check that the test is now working correctly for you?


> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1184?page=comments#action_12373649 ] 

Kristian Waagan commented on DERBY-1184:
----------------------------------------

Code changes are okay and works as expected, but the test has become out of synch with the SQL states.  In revision 392060, the SQL state "0AX01" was replaced by "0A000". I suggest a committer takes care of this simple change in the test derbynet/callable.java.

When the test is updated, the issue can be closed.

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Bryan Pendleton (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]
     
Bryan Pendleton resolved DERBY-1184:
------------------------------------

    Fix Version: 10.2.0.0
     Resolution: Fixed

Patch committed to subversion as revision 392304. Kristian, can you please confirm and close this issue? Thanks.

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Bryan Pendleton
>     Priority: Minor
>      Fix For: 10.2.0.0
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat, derby_1184_with_test.diff
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1184?page=comments#action_12373442 ] 

Kristian Waagan commented on DERBY-1184:
----------------------------------------

Yes, a test should be added, but since the existing test was canon based test, I did not find the time to add a test and update the canons. This is not my itch at the moment, I stumbled over this when working on a JDBC4 feature.
If it is of interest, I can add a test for this in the jdbc4/CallableStatementTest, but it would then only be run under JDK 1.6.
If the missing test is a blocker, I suggest the patch is put on hold until someone else find the time to write/update the test.

I created the quick patch because I found the bug quite ugly; a method pretending everything is okay, when it actually does nothing...

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Kristian Waagan reassigned DERBY-1184:
--------------------------------------

    Assign To: Kristian Waagan

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>     Priority: Minor

>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1184) 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1184?page=all ]

Kristian Waagan updated DERBY-1184:
-----------------------------------

    Attachment: derby-1184-1a.diff
                derby-1184-1a.stat

'derby-1184-1a.diff' changes the method CallableStatement.registerOutParameter(int,int,String) to throw a not-implemented exception. It was doing nothing before (no actions taken, no exceptions thrown except for the case where the method was called on a closed CallableStatement).

derbyall is running. I will report tomorrow if there are problems, but I don't expect that to be the case since the method is probably not used in any tests.

This patch fixes one of the differences between embedded and client driver reported in DERBY-477.

> 'CallableStatement.registerOutParameter(int,int,String)' does nothing in client driver
> --------------------------------------------------------------------------------------
>
>          Key: DERBY-1184
>          URL: http://issues.apache.org/jira/browse/DERBY-1184
>      Project: Derby
>         Type: Bug

>   Components: JDBC
>     Versions: 10.2.0.0
>  Environment: Derby network client
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>     Priority: Minor
>  Attachments: derby-1184-1a.diff, derby-1184-1a.stat
>
> The method 'CallableStatement.registerOutParameter(int,int,String)' does nothing in the client driver. As stated in DERBY-447, the method throws a not-implemented exception in the embedded driver. The method should be changed to do this on the client side as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira