[jira] Assigned: (TUSCANY-2836) DEFAULT_DESTINATION is not a Destination

["Simon Laws (JIRA)" <de...@tuscany.apache.org>]

     [ https://issues.apache.org/jira/browse/TUSCANY-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Laws reassigned TUSCANY-2836:
-----------------------------------

    Assignee: Simon Laws

> DEFAULT_DESTINATION is not  a Destination
> -----------------------------------------
>
>                 Key: TUSCANY-2836
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2836
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA JMS Binding Extension
>            Reporter: Tom Seelbach
>            Assignee: Simon Laws
>
> I suggest that the JMSBindingConstants DEFAULT_DESTINATION_NAME and DEFAULT_RESPONSE_DESTINATION_NAME should be removed. 
>     String DEFAULT_DESTINATION_NAME = "NODESTINATION";
>     String DEFAULT_RESPONSE_DESTINATION_NAME = "NORESPONSEDESTINATION";
> They are not really default destination names, but rather indicators that the Destination is unspecified.  This can lead to confusing code and bugs if one assumes that a destination should be null if it has not been specified.
>  
> The values in JMSBindingImpl.destinationName and JMSBinding.responseDestinationName should be null upon construction.
> Then the following would most likely be null checks instead of equals():
> ./org/apache/tuscany/sca/binding/jms/provider/JMSBindingInvoker.java:            
> if (JMSBindingConstants.DEFAULT_RESPONSE_DESTINATION_NAME.equals(queueName)) {
> ./org/apache/tuscany/sca/binding/jms/provider/JMSBindingReferenceBindingProvider.java:        
> if (jmsBinding.getDestinationName().equals(JMSBindingConstants.DEFAULT_DESTINATION_NAME)) {
> ./org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java:        
> if (jmsBinding.getDestinationName().equals(JMSBindingConstants.DEFAULT_DESTINATION_NAME)) {
> ./org/apache/tuscany/sca/binding/jms/provider/JMSBindingServiceBindingProvider.java:        
> if (service.isCallback() && JMSBindingConstants.DEFAULT_DESTINATION_NAME
> ./org/apache/tuscany/sca/binding/jms/provider/JMSResourceFactoryImpl.java:        
> if (JMSBindingConstants.DEFAULT_DESTINATION_NAME.equals(destName)) {
> ./org/apache/tuscany/sca/binding/jms/provider/RRBJMSBindingInvoker.java:            
> if (JMSBindingConstants.DEFAULT_RESPONSE_DESTINATION_NAME.equals(queueName)) {
> There are probably other ramifications which i haven't fully explored...
> thanks,
> Tom

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.