[GitHub] [superset] villebro commented on a change in pull request #16607: feat: add resample operator in post processing

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16607:
URL: https://github.com/apache/superset/pull/16607#discussion_r702821141



##########
File path: tests/integration_tests/pandas_postprocessing_tests.py
##########
@@ -870,3 +870,18 @@ def test_boxplot_percentile_incorrect_params(self):
                 metrics=["cars"],
                 percentiles=[10, 90, 10],
             )
+
+    def test_resample(self):
+        timeseries_df.index.name = "time_column"
+        timeseries_df.reset_index(inplace=True)

Review comment:
       we should probably make a deep copy of this before mutating it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org