You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2020/10/02 09:44:00 UTC

[jira] [Assigned] (YETUS-1013) The --sentinel option in test-patch.sh should also set ROBOT to true

     [ https://issues.apache.org/jira/browse/YETUS-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang reassigned YETUS-1013:
--------------------------------

    Assignee: Duo Zhang

> The --sentinel option in test-patch.sh should also set ROBOT to true
> --------------------------------------------------------------------
>
>                 Key: YETUS-1013
>                 URL: https://issues.apache.org/jira/browse/YETUS-1013
>             Project: Yetus
>          Issue Type: Bug
>          Components: Precommit
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>
> For now it only set SENTINEL to true.
> And in core.d/docker.sh, in the docker_container_maintenance method, we have this at the beginning:
> {code}
>   if [[ "${ROBOT}" = false ]]; then
>     return
>   fi
> {code}
> I think this will make us skip the docker cleanup step.
> In docker-cleanup.sh, we do have set ROBOT to true when parsing --sentinel but since in test-patch.sh, we have called delete_parameter so I'm afraid there is no way for docker-cleanup.sh to parse the parameter again?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)