You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/05 16:14:26 UTC

[GitHub] [incubator-nuttx] lukegluke opened a new pull request #1370: Fix wrong use of nxsem_getvalue

lukegluke opened a new pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370


   Bug caused increase of fifo->rx_sem with each received msg until finally after 32767 messages get into
   DEBUGASSERT(sem->semcount<SEM_VALUE_MAX);
   or stopping receiving anything at all without debug, while tx was working.
   
   issue #1354 
   
   Also perform can_poll inside critical_section. I'm not sure, maybe it not necessary, please advise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] lukegluke edited a comment on pull request #1370: Fix wrong use of nxsem_getvalue

Posted by GitBox <gi...@apache.org>.
lukegluke edited a comment on pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370#issuecomment-653917852


   Thank for you work, Alan! But it looks like a made a mistake :(
   Should be
   `sval <= 0`
   right? 
   
   `If 'sem' is locked, the value return by nxsem_get_value() will either be zero or a negative number whose absolute value represents the number of tasks waiting for the semaphore.`
   
   Sorry for inconvenient and rush.
   Made #1371
   
   Also I'm still not sure about critical section necessity.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] lukegluke edited a comment on pull request #1370: Fix wrong use of nxsem_getvalue

Posted by GitBox <gi...@apache.org>.
lukegluke edited a comment on pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370#issuecomment-653917852






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] lukegluke commented on pull request #1370: Fix wrong use of nxsem_getvalue

Posted by GitBox <gi...@apache.org>.
lukegluke commented on pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370#issuecomment-653917852


   Thank for you work, Alan! But it looks like a made a mistake :(
   Should be
   `sval <= 0`
   right? 
   
   `If 'sem' is locked, the value return by nxsem_get_value() will either be zero or a negative number whose absolute value represents the number of tasks waiting for the semaphore.`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1370: Fix wrong use of nxsem_getvalue

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1370: Fix wrong use of nxsem_getvalue

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1370:
URL: https://github.com/apache/incubator-nuttx/pull/1370#issuecomment-653917009


   Good catch Oleg! Thank you very much!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org