[jira] [Resolved] (COUCHDB-2722) The keys from the rewrited query params of a view should be blank when not specified in the URL

["Martin Lagrange (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COUCHDB-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Lagrange resolved COUCHDB-2722.
--------------------------------------
    Resolution: Fixed

Hi everyone, 
I have made a fix.

Here are the pull requests :
https://github.com/apache/couchdb/pull/324
https://github.com/apache/couchdb-couch/pull/59
https://github.com/apache/couchdb-chttpd/pull/36

Any comment, review is always welcome :-)
cc [~robertkowalski]

> The keys from the rewrited query params of a view should be blank when not specified in the URL
> -----------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-2722
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2722
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: HTTP Interface
>    Affects Versions: 1.5.1, 1.6.0, 1.6.1
>            Reporter: Martin Lagrange
>            Priority: Minor
>
> When we rewrite the query params of a view as in the following example :
>  
> {code:title=Design document test|borderStyle=solid}
> {
>  _id:"_design/test",
> views : {
>             rewriteKeyView: { 
>                                            // ...  
>                           }
>         },
> rewrites: [
>             {
>                "from": "renamedRewriteKeyView",
>                "to": "_view/rewriteKeyView",
>                "query": {
>                    "startkey": [
>                        ":by"
>                    ],
>                    "endkey": [
>                        ":by",
>                        {}
>                    ]
>                }
>              }
>           ]
> }
> {code}
> specifying the param *by* as the main component of startkey and endkey
> When we access the renamed view "renamedRewriteKeyView", without specifying the by param in the URI like : 
> {code}GET dbName/_design/test/renamedRewriteKeyView{code}
> the internal call should be : {code}rewriteKeyView?startkey=[""]&endkey=["",{}]{code}
> instead of : {code}rewriteKeyView?startkey=[":by"]&endkey=[":by",{}]{code}
> As you can see, when a key is not specified in the URI, it the value of this key will be kept as its name. Quite annoying in some cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)