You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/20 06:44:20 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new issue, #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
jamesnetherton opened a new issue, #3798:
URL: https://github.com/apache/camel-quarkus/issues/3798
Something in the Camel 3.17.0 upgrade has maybe introduced some flakiness in this test. Occasionally it fails because the expected statistic values are not present.
```
2022-05-19T22:49:33.9201865Z [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.876 s <<< FAILURE! - in org.apache.camel.quarkus.core.converter.it.ConverterTest
2022-05-19T22:49:33.9202961Z [ERROR] testConverterGetStatistics Time elapsed: 0.081 s <<< FAILURE!
2022-05-19T22:49:33.9203814Z java.lang.AssertionError:
2022-05-19T22:49:33.9204317Z 1 expectation failed.
2022-05-19T22:49:33.9205117Z JSON path miss doesn't match.
2022-05-19T22:49:33.9205892Z Expected: is <0>
2022-05-19T22:49:33.9206561Z Actual: <1>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3798:
URL: https://github.com/apache/camel-quarkus/issues/3798#issuecomment-1152420531
I have not seen any recent failures. I think https://github.com/apache/camel-quarkus/commit/9e8ef91462487c15a52209393466b1fb3a2b76e1 has fixed this. My suspicion was that the timer producer was left running across multiple tests and was thus affecting the type converter stats and introducing racy results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3798:
URL: https://github.com/apache/camel-quarkus/issues/3798#issuecomment-1139586002
I can't replicate this locally. But it frequently happens on the CI builds. Latest instance reports:
```
2022-05-27T05:36:24.9585232Z JSON path miss doesn't match.
2022-05-27T05:36:24.9585445Z Expected: is <1>
2022-05-27T05:36:24.9585755Z Actual: <2>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #3798:
URL: https://github.com/apache/camel-quarkus/issues/3798#issuecomment-1141042775
Spotted 3 occurences:
https://github.com/apache/camel-quarkus/runs/6516157679?check_suite_focus=true#step:9:36230
https://github.com/apache/camel-quarkus/runs/6567639507?check_suite_focus=true#step:9:36249
https://github.com/apache/camel-quarkus/runs/6625038572?check_suite_focus=true#step:8:5764
It happened in `integation-tests-alternative-jdk` and once in `Native tests - group-03` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3798:
URL: https://github.com/apache/camel-quarkus/issues/3798#issuecomment-1143633419
Could be this change that caused this:
https://github.com/apache/camel/commit/74ef8acbf7278832e6246ea7bac7edb20f1dcea8#diff-ef06b38c2c6af7e2218d24d087d5014d0b4cefb7662c92c4a8b7a90406a8c5a2
The other thing I noticed is that the JavaDoc accompanying `LongAdder.reset()` states:
> Because this method is intrinsically racy, it should only be used when it is known that no threads are concurrently updating
I wonder if we should be bothering to validate the statistics at all? The main thing to focus on is whether type conversion is working correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #3798: Intermittent failure of `ConverterTest.testConverterGetStatistics`
URL: https://github.com/apache/camel-quarkus/issues/3798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org