[jira] [Commented] (ARROW-10626) [Rust] Rust lint / clippy settings allows warnings

["Andrew Lamb (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286753#comment-17286753 ] 

Andrew Lamb commented on ARROW-10626:
-------------------------------------

this is no longer valid

> [Rust] Rust  lint /  clippy settings allows warnings
> ----------------------------------------------------
>
>                 Key: ARROW-10626
>                 URL: https://issues.apache.org/jira/browse/ARROW-10626
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Andrew Lamb
>            Assignee: Andrew Lamb
>            Priority: Minor
>
> We do currently run clippy (aka rust linter) on all PRs. However, the way we invoke clippy means that any clippy warnings introduced in PRs do not cause a CI failure
> I believe the intended behavior is that we keep the arrow project "Clippy clean"
> For example, this PR (doesn't introduce the warning), but clippy flags a warning and yet the test still apsses:
> https://github.com/apache/arrow/runs/1408182529?check_suite_focus=true
> {code}
>     Checking arrow v3.0.0-SNAPSHOT (/Users/runner/work/arrow/arrow/rust/arrow)
> warning: unneeded unit return type
>    --> arrow/src/buffer.rs:694:45
>     |
> 694 |     pub fn resize(&mut self, new_len: usize) -> () {
>     |                                             ^^^^^^ help: remove the `-> ()`
>     |
>     = note: `#[warn(clippy::unused_unit)]` on by default
>     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
> warning: 1 warning emitted
>     Finished dev [unoptimized + debuginfo] target(s) in 1m 11s
> ~/work/arrow/arrow
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)