You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Noel J. Bergman (JIRA)" <se...@james.apache.org> on 2006/11/03 15:16:16 UTC
[jira] Created: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
------------------------------------------------------------------------------------------------------------------
Key: JAMES-670
URL: http://issues.apache.org/jira/browse/JAMES-670
Project: James
Issue Type: Bug
Affects Versions: Next Major, Trunk
Reporter: Noel J. Bergman
Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-670?page=all ]
Norman Maurer reassigned JAMES-670:
-----------------------------------
Assignee: Norman Maurer
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: http://issues.apache.org/jira/browse/JAMES-670
> Project: James
> Issue Type: New Feature
> Affects Versions: Next Major, Trunk
> Reporter: Noel J. Bergman
> Assigned To: Norman Maurer
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-670?page=all ]
Stefano Bagnara updated JAMES-670:
----------------------------------
Issue Type: New Feature (was: Bug)
Marked as a new feature: it is different to limit connections per service or per application and the proposed change does not include the current behaviour.
So, if anyone want to implement this improvement, please leave us also the old behaviour :-)
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: http://issues.apache.org/jira/browse/JAMES-670
> Project: James
> Issue Type: New Feature
> Affects Versions: Next Major, Trunk
> Reporter: Noel J. Bergman
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12448442 ]
Norman Maurer commented on JAMES-670:
-------------------------------------
I leave this open cause maybe it whould be a better solution to create a new connectionmanager and specify this connectionmanager in assembly.xml to add this feature..
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: http://issues.apache.org/jira/browse/JAMES-670
> Project: James
> Issue Type: New Feature
> Affects Versions: Next Major, Trunk
> Reporter: Noel J. Bergman
> Assigned To: Norman Maurer
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer resolved JAMES-670.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: Trunk)
3.0-M1
We now use ConnectionFilter todo this stuff in MINA. So I will close this..
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: https://issues.apache.org/jira/browse/JAMES-670
> Project: JAMES Server
> Issue Type: New Feature
> Affects Versions: 3.0, Trunk
> Reporter: Noel J. Bergman
> Assignee: Norman Maurer
> Fix For: 3.0-M1
>
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12449335 ]
Stefano Bagnara commented on JAMES-670:
---------------------------------------
I see this feature changed more code than I thought.
I would prefer it to be contained in a different class, is it possible?
I also noticed that there is a lot of int<->Integer<->String conversions in ConnectionPerIpMap and this could be made much more performant by using only ints.
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: http://issues.apache.org/jira/browse/JAMES-670
> Project: James
> Issue Type: New Feature
> Affects Versions: Next Major, Trunk
> Reporter: Noel J. Bergman
> Assigned To: Norman Maurer
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during initialization.
Posted by Stefano Bagnara <ap...@bago.org>.
Any comment about this issue?
I would like to revert to the previous version and only keep the
String=>Integer improvement, but I want to hear your opinions...
As I said a better configurability can be already achieved with the
previous version by creating server specific connection managers in the
assembly/config.
Should I elaborate on the real configuration or is it already clear?
Stefano
Stefano Bagnara wrote:
> I think that the 2 features are overlapping and it would be much better
> to expose the simpler in config.xml and leave the other in alternative
> classes/packages.
>
> I think that an overall "connections per ip" limit is better and enough
> for most users and the "connections per service per ip" won't give a
> better result in most common scenarios.
>
> My proposal is to keep the connections per ip limit in the base code and
> to optionally provide classes and informations (and maybe comments in
> the assembly/config.xml) to support the other.
>
> I think that the "connection per service per ip" could be achieved by
> simply creating multiple instances of the connectionManager in the
> assembly and wire them in the desired way. This was already feasible
> without code changes.
>
> Either way the refactoring to remove the int<=>String conversions would
> be a good improvement.
>
> Stefano
>
> Norman Maurer (JIRA) wrote:
>> [
>> http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12449337
>> ] Norman Maurer commented on JAMES-670:
>> -------------------------------------
>>
>> Sure its possible.. I also thought about this before i did the
>> changes.. But remember that whould also need changes to assembly.xml
>> again etc... But if all agree i can refactor it..
>>
>>
>>> Per IP connection limiting is not configurable per service, nor is
>>> the configuration logged during initialization.
>>> ------------------------------------------------------------------------------------------------------------------
>>>
>>>
>>> Key: JAMES-670
>>> URL: http://issues.apache.org/jira/browse/JAMES-670
>>> Project: James
>>> Issue Type: New Feature
>>> Affects Versions: Next Major, Trunk
>>> Reporter: Noel J. Bergman
>>> Assigned To: Norman Maurer
>>>
>>> Per IP connection limiting is not configurable per service, nor is
>>> the configuration logged during initialization.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during initialization.
Posted by Stefano Bagnara <ap...@bago.org>.
I think that the 2 features are overlapping and it would be much better
to expose the simpler in config.xml and leave the other in alternative
classes/packages.
I think that an overall "connections per ip" limit is better and enough
for most users and the "connections per service per ip" won't give a
better result in most common scenarios.
My proposal is to keep the connections per ip limit in the base code and
to optionally provide classes and informations (and maybe comments in
the assembly/config.xml) to support the other.
I think that the "connection per service per ip" could be achieved by
simply creating multiple instances of the connectionManager in the
assembly and wire them in the desired way. This was already feasible
without code changes.
Either way the refactoring to remove the int<=>String conversions would
be a good improvement.
Stefano
Norman Maurer (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12449337 ]
>
> Norman Maurer commented on JAMES-670:
> -------------------------------------
>
> Sure its possible.. I also thought about this before i did the changes.. But remember that whould also need changes to assembly.xml again etc... But if all agree i can refactor it..
>
>
>> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
>> ------------------------------------------------------------------------------------------------------------------
>>
>> Key: JAMES-670
>> URL: http://issues.apache.org/jira/browse/JAMES-670
>> Project: James
>> Issue Type: New Feature
>> Affects Versions: Next Major, Trunk
>> Reporter: Noel J. Bergman
>> Assigned To: Norman Maurer
>>
>> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-670) Per IP connection limiting is not
configurable per service, nor is the configuration logged during
initialization.
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-670?page=comments#action_12449337 ]
Norman Maurer commented on JAMES-670:
-------------------------------------
Sure its possible.. I also thought about this before i did the changes.. But remember that whould also need changes to assembly.xml again etc... But if all agree i can refactor it..
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-670
> URL: http://issues.apache.org/jira/browse/JAMES-670
> Project: James
> Issue Type: New Feature
> Affects Versions: Next Major, Trunk
> Reporter: Noel J. Bergman
> Assigned To: Norman Maurer
>
> Per IP connection limiting is not configurable per service, nor is the configuration logged during initialization.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org