You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2017/09/22 19:58:32 UTC
[GitHub] metron pull request #771: METRON-1204: UI does not time out after being idle...
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/771
METRON-1204: UI does not time out after being idle, but stops functioning
## Contributor Comments
This fix was verified running the Alerts UI against full dev. To test this fix, spin up full dev and start the Alerts UI. After logging into the Alerts UI, let it sit for a while until it idles out. When this happens the UI should automatically navigate back to the login page.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #771
----
commit 368afe25f53cca9bc7adda5a13941c6332872e29
Author: merrimanr <me...@gmail.com>
Date: 2017-09-22T19:55:15Z
removed extra res.json() call
----
---
[GitHub] metron pull request #771: METRON-1204: UI does not time out after being idle...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/771
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
This brings up the issue with having 'split' these uis. They have common things that we shouldn't have to duplicate in each application.
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by iraghumitra <gi...@git.apache.org>.
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/771
+1 works as described ...
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
Our common components should be identified and moved to angular libraries as much as possible
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/771
The latest commit adds a "Session Expired" message on the login page and also applies the fix to the Management UI. You will notice the 2 files look identical between metron-alerts and metron-config. We might want to investigate a way to share components in the future.
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/771
+1 by inspection, great job @merrimanr
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by iraghumitra <gi...@git.apache.org>.
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/771
Tested, the UI redirects to log-in after the timeout. Should we show a message on the login page that session timeout happened ?.
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
definitely
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/771
@ottobackwards should we push that as a follow up issue for now rather than expanding the scope of this PR?
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/771
That's not a bad idea. It occurs to me that this issue may also exist with the Management UI and should be fixed there as well. Stay tuned.
---
[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
[METRON-1221 Shared Metron Angular Components](https://issues.apache.org/jira/browse/METRON-1221)
---