You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "jsbxyyx (via GitHub)" <gi...@apache.org> on 2024/01/08 09:11:23 UTC
[PR] bugfix: resultSet, statement and connection close sequence [incubator-seata]
jsbxyyx opened a new pull request, #6248:
URL: https://github.com/apache/incubator-seata/pull/6248
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes: #6224
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: JDBC resultSet, statement and connection closing order [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6248:
URL: https://github.com/apache/incubator-seata/pull/6248#issuecomment-1880630348
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `24 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`2363715`)](https://app.codecov.io/gh/apache/incubator-seata/commit/2363715c05529ddd6d5aa6c2472bd550e4c7cabf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.97% compared to head [(`654c570`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.85%.
> Report is 6 commits behind head on 2.x.
> :exclamation: Current head 654c570 differs from pull request most recent head f1845fa. Consider uploading reports for the commit f1845fa to get more accurate results
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6248 +/- ##
============================================
- Coverage 49.97% 49.85% -0.13%
- Complexity 4928 4933 +5
============================================
Files 915 917 +2
Lines 31927 32010 +83
Branches 3855 3862 +7
============================================
+ Hits 15954 15957 +3
- Misses 14406 14494 +88
+ Partials 1567 1559 -8
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../rm/datasource/exec/BaseTransactionalExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3JtL2RhdGFzb3VyY2UvZXhlYy9CYXNlVHJhbnNhY3Rpb25hbEV4ZWN1dG9yLmphdmE=) | `74.00% <100.00%> (+0.26%)` | :arrow_up: |
| [.../seata/rm/datasource/exec/MultiUpdateExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3JtL2RhdGFzb3VyY2UvZXhlYy9NdWx0aVVwZGF0ZUV4ZWN1dG9yLmphdmE=) | `80.26% <100.00%> (+0.26%)` | :arrow_up: |
| [...va/io/seata/rm/datasource/exec/UpdateExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3JtL2RhdGFzb3VyY2UvZXhlYy9VcGRhdGVFeGVjdXRvci5qYXZh) | `84.09% <100.00%> (+0.36%)` | :arrow_up: |
| [...datasource/exec/mysql/MySQLUpdateJoinExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3JtL2RhdGFzb3VyY2UvZXhlYy9teXNxbC9NeVNRTFVwZGF0ZUpvaW5FeGVjdXRvci5qYXZh) | `78.48% <100.00%> (+0.13%)` | :arrow_up: |
| [...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL2lvL3NlYXRhL3JtL2RhdGFzb3VyY2UvZXhlYy9teXNxbC9NeVNRTEluc2VydE9uRHVwbGljYXRlVXBkYXRlRXhlY3V0b3IuamF2YQ==) | `32.16% <0.00%> (-0.17%)` | :arrow_down: |
| [...er/console/impl/db/BranchSessionDBServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvaW8vc2VhdGEvc2VydmVyL2NvbnNvbGUvaW1wbC9kYi9CcmFuY2hTZXNzaW9uREJTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...erver/console/impl/db/GlobalLockDBServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvaW8vc2VhdGEvc2VydmVyL2NvbnNvbGUvaW1wbC9kYi9HbG9iYWxMb2NrREJTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...er/console/impl/db/GlobalSessionDBServiceImpl.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvaW8vc2VhdGEvc2VydmVyL2NvbnNvbGUvaW1wbC9kYi9HbG9iYWxTZXNzaW9uREJTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6248/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: JDBC resultSet, statement and connection closing order [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6248:
URL: https://github.com/apache/incubator-seata/pull/6248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org