You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/22 13:44:54 UTC
[GitHub] [cloudstack] GaOrtiga opened a new pull request, #6917: Improvements and cleanup on the javadocs of qeumu img
GaOrtiga opened a new pull request, #6917:
URL: https://github.com/apache/cloudstack/pull/6917
### Description
This PR improves the javadocs of the class `QemuImg` by fixing grammatical errors, cleaning up methods that were not implemented, enhancing existing documentation and adding new.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
I built the code in a local lab and checked that there were no errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6917: Improvements and cleanup on the javadocs of qeumu img
Posted by GitBox <gi...@apache.org>.
stephankruggg commented on code in PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#discussion_r1030680395
##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java:
##########
@@ -140,43 +140,50 @@ public QemuImg(final int timeout, final boolean skipZeroIfSupported, final boole
this.version = LibvirtConnection.getConnection().getVersion();
}
+ /**
+ * Creates a QemuImg object.
+ *
+ * @param timeout
+ * The timeout of scripts executed by this QemuImg object.
+ */
public QemuImg(final int timeout) throws LibvirtException, QemuImgException {
this(timeout, false, false);
}
+ /**
+ * Sets the timeout for the scripts executed by this QemuImg object.
Review Comment:
```suggestion
* Sets the timeout of the scripts executed by this QemuImg object.
```
##########
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java:
##########
@@ -140,43 +140,50 @@ public QemuImg(final int timeout, final boolean skipZeroIfSupported, final boole
this.version = LibvirtConnection.getConnection().getVersion();
}
+ /**
+ * Creates a QemuImg object.
+ *
+ * @param timeout
+ * The timeout of scripts executed by this QemuImg object.
+ */
public QemuImg(final int timeout) throws LibvirtException, QemuImgException {
this(timeout, false, false);
}
+ /**
+ * Sets the timeout for the scripts executed by this QemuImg object.
+ *
+ * @param timeout
+ * The timeout for the object.
Review Comment:
```suggestion
* The timeout of the object.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334124614
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1339500170
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6917: Improvements and cleanup on the javadocs of qeumu img
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1323810227
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6917)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6917: Improvements and cleanup on the javadocs of qeumu img
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1326453030
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6917)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6917&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6917&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6917&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1335767747
<b>Trillian test result (tid-5344)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40114 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6917-t5344-kvm-centos7.zip
Smoke tests completed. 101 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_07_arping_in_vr | `Failure` | 5.19 | test_diagnostics.py
test_create_pvlan_network | `Error` | 0.05 | test_pvlan.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 549.12 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1339434907
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1329438132
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
GutoVeronezi merged PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1332166567
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334899776
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1339997905
Merging this one based on test and packaging results and approvals. Errors in https://github.com/apache/cloudstack/pull/6917#issuecomment-1335767747 does not seem related to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1339436463
@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334900648
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334014029
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1329343425
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1329342003
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6917: Improvements and cleanup on the javadocs of qeumu img
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6917:
URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1323768461
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6917](https://codecov.io/gh/apache/cloudstack/pull/6917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddab1c7) into [main](https://codecov.io/gh/apache/cloudstack/commit/c5e657ddd80faa93585aef1381e30b7e2d9a9eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5e657d) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6917 +/- ##
=========================================
Coverage 10.87% 10.87%
Complexity 7117 7117
=========================================
Files 2485 2485
Lines 245507 245505 -2
Branches 38334 38334
=========================================
Hits 26699 26699
+ Misses 215538 215536 -2
Partials 3270 3270
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/cloudstack/utils/qemu/QemuImg.java](https://codecov.io/gh/apache/cloudstack/pull/6917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svdXRpbHMvcWVtdS9RZW11SW1nLmphdmE=) | `2.19% <0.00%> (+0.01%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org