[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10982: Allow extra aggregation types in RealtimeToOfflineSegmentsTask

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10982:
URL: https://github.com/apache/pinot/pull/10982#discussion_r1253930820


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -103,7 +105,7 @@ private TableConfigUtils() {
   // hardcode the value here to avoid pulling the entire pinot-kinesis module as dependency.
   private static final String KINESIS_STREAM_TYPE = "kinesis";
   private static final EnumSet<AggregationFunctionType> SUPPORTED_INGESTION_AGGREGATIONS =
-      EnumSet.of(AggregationFunctionType.SUM, AggregationFunctionType.MIN, AggregationFunctionType.MAX,
+      EnumSet.of(AggregationFunctionType.SUM, MIN, AggregationFunctionType.MAX,

Review Comment:
   ```suggestion
         EnumSet.of(SUM, MIN, MAX, COUNT);
   ```



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -483,6 +485,14 @@ static void validateDecoder(StreamConfig streamConfig) {
     }
   }
 
+  public final static Set<AggregationFunctionType> AVAILABLE_CORE_VALUE_AGGREGATORS = Set.of(

Review Comment:
   Let's use `EnumSet` here, and reformat the change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org