You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/04/25 12:48:28 UTC
Review Request 46630: Some agents improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46630/
-----------------------------------------------------------
Review request for ranger.
Repository: ranger
Description
-------
Some agents improvements:
a) No need to use lazy init with the associating synchronized hit to load the RangerCredentialProvider.
b) The RangerCredentialProviderTest is writing a keystore to the user home directory! This is changed to write to a temporary file instead
c) The agents-installer module only needs commons-cli and not the whole hadoop-client set of dependencies
d) The "PasswordGenerator" is using Random instead of SecureRandom!!?
e) The XmlConfigChanger should be enabling secure processing when parsing into DOM.
Diffs
-----
agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java d3faf60
agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 686318b
agents-installer/pom.xml 97837a8
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java 3632c1a
agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 9d0cbed
Diff: https://reviews.apache.org/r/46630/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46630: RANGER-949 - Some agents improvements
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46630/
-----------------------------------------------------------
(Updated July 11, 2016, 3:09 p.m.)
Review request for ranger.
Bugs: RANGER-949
https://issues.apache.org/jira/browse/RANGER-949
Repository: ranger
Description
-------
Some agents improvements:
a) No need to use lazy init with the associating synchronized hit to load the RangerCredentialProvider.
b) The RangerCredentialProviderTest is writing a keystore to the user home directory! This is changed to write to a temporary file instead
c) The agents-installer module only needs commons-cli and not the whole hadoop-client set of dependencies
d) The "PasswordGenerator" is using Random instead of SecureRandom!!?
e) The XmlConfigChanger should be enabling secure processing when parsing into DOM.
Diffs
-----
agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java d3faf60
agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 686318b
agents-installer/pom.xml 97837a8
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java 3632c1a
agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 9d0cbed
Diff: https://reviews.apache.org/r/46630/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 46630: RANGER-949 - Some agents improvements
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46630/
-----------------------------------------------------------
(Updated April 27, 2016, 12:46 p.m.)
Review request for ranger.
Summary (updated)
-----------------
RANGER-949 - Some agents improvements
Repository: ranger
Description
-------
Some agents improvements:
a) No need to use lazy init with the associating synchronized hit to load the RangerCredentialProvider.
b) The RangerCredentialProviderTest is writing a keystore to the user home directory! This is changed to write to a temporary file instead
c) The agents-installer module only needs commons-cli and not the whole hadoop-client set of dependencies
d) The "PasswordGenerator" is using Random instead of SecureRandom!!?
e) The XmlConfigChanger should be enabling secure processing when parsing into DOM.
Diffs
-----
agents-cred/src/main/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProvider.java d3faf60
agents-cred/src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java 686318b
agents-installer/pom.xml 97837a8
agents-installer/src/main/java/org/apache/ranger/utils/install/PasswordGenerator.java 3632c1a
agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java 9d0cbed
Diff: https://reviews.apache.org/r/46630/diff/
Testing
-------
Thanks,
Colm O hEigeartaigh