You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/06/22 18:11:20 UTC

[8/8] impala git commit: IMPALA-5763: [DOCS] Warn against setting --logbufsecs to 0

IMPALA-5763: [DOCS] Warn against setting --logbufsecs to 0

Change-Id: I45d14e2ba601574cf76a4b739617b097f3e551aa
Reviewed-on: http://gerrit.cloudera.org:8080/10790
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/15e4f06c
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/15e4f06c
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/15e4f06c

Branch: refs/heads/master
Commit: 15e4f06cf6039c95dc0697fe8131d35a2ad89b5c
Parents: fdc3873
Author: Alex Rodoni <ar...@cloudera.com>
Authored: Thu Jun 21 16:09:18 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Fri Jun 22 16:35:41 2018 +0000

----------------------------------------------------------------------
 docs/topics/impala_logging.xml | 57 ++++++++++++++++++++++++-------------
 1 file changed, 38 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/15e4f06c/docs/topics/impala_logging.xml
----------------------------------------------------------------------
diff --git a/docs/topics/impala_logging.xml b/docs/topics/impala_logging.xml
index 6246ac6..22e149e 100644
--- a/docs/topics/impala_logging.xml
+++ b/docs/topics/impala_logging.xml
@@ -215,30 +215,49 @@ under the License.
       </p>
 
       <p>
-        Impala can automatically remove older unneeded log files, a feature known as <term>log rotation</term>.
-<!-- Another instance of the text also used in impala_new_features.xml
-             and impala_fixed_issues.xml. (Just took out the word "new"
-             and added the reference to the starting release.)
-             At this point, a conref is definitely in the cards. -->
+        Impala can automatically remove older unneeded log files, a feature
+        known as <term>log rotation</term>.
       </p>
 
       <p>
-        In Impala 2.2 and higher, the <codeph>--max_log_files</codeph> configuration option specifies how many log
-        files to keep at each severity level. You can specify an appropriate setting for each Impala-related daemon
-        (<cmdname>impalad</cmdname>, <cmdname>statestored</cmdname>, and <cmdname>catalogd</cmdname>). The default
-        value is 10, meaning that Impala preserves the latest 10 log files for each severity level
-        (<codeph>INFO</codeph>, <codeph>WARNING</codeph>, <codeph>ERROR</codeph>, and <codeph>FATAL</codeph>).
-        Impala checks to see if any old logs need to be removed based on the interval specified in the
-        <codeph>logbufsecs</codeph> setting, every 5 seconds by default.
+        In Impala 2.2 and higher, the <codeph>--max_log_files</codeph>
+        configuration option specifies how many log files to keep at each
+        severity level (<codeph>INFO</codeph>, <codeph>WARNING</codeph>,
+          <codeph>ERROR</codeph>, and <codeph>FATAL</codeph>). You can specify
+        an appropriate setting for each Impala-related daemon
+          (<cmdname>impalad</cmdname>, <cmdname>statestored</cmdname>, and
+          <cmdname>catalogd</cmdname>).
+        <ul>
+          <li>
+            A value of 0 preserves all log files, in which case you would set
+            up set up manual log rotation using your Linux tool or technique of
+            choice.
+          </li>
+          <li>
+            A value of 1 preserves only the very latest log file.
+          </li>
+          <li>
+            The default value is 10.
+          </li>
+        </ul>
+      </p>
+      <p>
+        Impala checks to see if any old logs need to be removed based on the
+        interval specified in the <codeph>--logbufsecs</codeph> setting, every 5
+        seconds by default.
+      </p>
+      <p>
+        For some log levels, Impala logs are first temporarily buffered in
+        memory and only written to disk periodically. The
+          <codeph>--logbufsecs</codeph> setting controls the maximum time that
+        log messages are buffered for. For example, with the default value of 5
+        seconds, there may be up to a 5 second delay before a logged message
+        shows up in the log file.
       </p>
-
-<!-- This extra detail only appears here. Consider if it's worth including it
-           in the conref so people don't need to follow a link just for a couple of
-           minor factoids. -->
-
       <p>
-        A value of 0 preserves all log files, in which case you would set up set up manual log rotation using your
-        Linux tool or technique of choice. A value of 1 preserves only the very latest log file.
+        It is not recommended that you set <codeph>--logbufsecs</codeph> to 0
+        as the setting makes the Impala daemon to spin in the thread that tries
+        to delete old log files.
       </p>
 
     </conbody>