You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JihongMA <gi...@git.apache.org> on 2015/09/16 18:25:45 UTC

[GitHub] spark pull request: SPARK-9296 (add variance support)

GitHub user JihongMA opened a pull request:

    https://github.com/apache/spark/pull/8778

    SPARK-9296 (add variance support)

     extending variance support which leverages stddev implementation. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JihongMA/spark-1 SPARK-SQL

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8778
    
----
commit 7eb239b677b9d345efd834004dd32fd291c929e4
Author: Jihong MA <ji...@jihongs-macbook-pro.local>
Date:   2015-09-16T06:54:32Z

    add variance support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-9296 (add variance support)

Posted by JihongMA <gi...@git.apache.org>.
Github user JihongMA commented on the pull request:

    https://github.com/apache/spark/pull/8778#issuecomment-152441928
  
    closing this pull request. based on the performance comparison of Declartive vs. Imperative aggregate (SPARK-10953), the implementation of central moment computation will be based on Imperative aggregate approach (SPARK-10641)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-9296 (add variance support)

Posted by JihongMA <gi...@git.apache.org>.
Github user JihongMA closed the pull request at:

    https://github.com/apache/spark/pull/8778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-9296 (add variance support)

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/8778#issuecomment-140794391
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org