You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/02/09 06:17:43 UTC
[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9266
to review the following change.
Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
An additional case of KUDU-2274 found during stress testing was that
RaftConsensus will return a ConsensusStatePB from the ConsensusState()
RPC method even when shutdown. This patch prevents that.
TODO: Needs a test.
Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver_path_handlers.cc
10 files changed, 63 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9266/1
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc@412
PS2, Line 412: if (!s.ok()) continue; // This replica is shut down or failed.
Would it make sense to check for the specific type of the non-OK status here, and continue only in case of IsServiceUnavailable()?
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/master/catalog_manager.cc@4365
PS2, Line 4365: catalog_status_ = s.CloneAndPrepend("ConsensusState is not available");
I think it's worth explicitly setting the status to ServiceUnavailable() here: there is some logic that assumes that other components would retry in that case.
Or just add DCHECK(s.IsServiceUnavailable()) here. I'm just concerned about the behavior of the clients trying to connect to the master when if we return anything but ServiceUnavailable here.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc
File src/kudu/tserver/tablet_copy_source_session.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc@194
PS2, Line 194: RETURN_NOT_OK_PREPEND(consensus->ConsensusState(&cstate),
Maybe, it's worth adding DCHECK_OK() here as well? Isn't a logical error to initiate tablet copy source session from a tablet which has been shutdown? Or that's acceptable during initialization of a tablet server?
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc@194
PS2, Line 194: RETURN_NOT_OK_PREPEND(consensus->ConsensusState(&cstate),
: "Consensus state not available");
Would
RETURN_NOT_OK_PREPEND(consensus->ConsensusState(&initial_cstate_),
"Consensus state not available");
be acceptable here?
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_server-test.cc@423
PS2, Line 423: replica->SetError(Status::IOError("This error will leave the replica FAILED state at shutdown"));
: replica->Shutdown();
nit: maybe, separate these two cases to make sure that having just one is enough to get ServiceUnavailable error on while trying to call RaftConsensus::ConsensusState() method.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_service.cc@1220
PS2, Line 1220: continue;
Does it make sense to add before continue
DCHECK(s.IsServiceUnavailable());
?
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tserver_path_handlers.cc@294
PS2, Line 294: Status s = consensus->ConsensusState(&cstate);
: if (s.ok()) {
: consensus_state_html = ConsensusStatePBToHtml(cstate);
: }
nit: maybe just
if (consensus->ConsensusState(&cstate).ok()) {
consensus_state_html = ConsensusStatePBToHtml(cstate);
}
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 02:22:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc@412
PS2, Line 412: if (!s.ok()) continue; // This replica is shut down or failed.
> Would it make sense to check for the specific type of the non-OK status her
Done
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/master/catalog_manager.cc@4365
PS2, Line 4365: catalog_status_ = s.CloneAndPrepend("ConsensusState is not available");
> I think it's worth explicitly setting the status to ServiceUnavailable() he
Added a DCHECK.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc
File src/kudu/tserver/tablet_copy_source_session.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc@194
PS2, Line 194: RETURN_NOT_OK_PREPEND(consensus->ConsensusState(&cstate),
> Maybe, it's worth adding DCHECK_OK() here as well? Isn't a logical error t
There isn't anything preventing shutting down consensus while this is running so I think we want to leave this here.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_copy_source_session.cc@194
PS2, Line 194: RETURN_NOT_OK_PREPEND(consensus->ConsensusState(&cstate),
: "Consensus state not available");
> Would
I can do that if we want to guarantee that there will be no side effects to the out-param on failure. Actually the implementation already does that so I can do this and make that guarantee in the header file docs.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_server-test.cc@423
PS2, Line 423: replica->SetError(Status::IOError("This error will leave the replica FAILED state at shutdown"));
: replica->Shutdown();
> nit: maybe, separate these two cases to make sure that having just one is e
That is just how failure works (you need both calls) so I think we should leave it.
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tablet_service.cc@1220
PS2, Line 1220: continue;
> Does it make sense to add before continue
Done
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/9266/2/src/kudu/tserver/tserver_path_handlers.cc@294
PS2, Line 294: Status s = consensus->ConsensusState(&cstate);
: if (s.ok()) {
: consensus_state_html = ConsensusStatePBToHtml(cstate);
: }
> nit: maybe just
Done
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 10 Feb 2018 22:14:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9266
to look at the new patch set (#2).
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
KUDU-2274. RaftConsensus should not access cmeta when shutdown
An additional case of KUDU-2274 found during stress testing was that
RaftConsensus will return a ConsensusStatePB from the ConsensusState()
RPC method even when shutdown. This patch prevents that.
Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver_path_handlers.cc
11 files changed, 85 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9266/2
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9266
to look at the new patch set (#4).
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
KUDU-2274. RaftConsensus should not access cmeta when shutdown
An additional case of KUDU-2274 found during stress testing was that
RaftConsensus will return a ConsensusStatePB from the ConsensusState()
RPC method even when shutdown. This patch prevents that.
Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver_path_handlers.cc
11 files changed, 88 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9266/4
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Sun, 11 Feb 2018 06:38:49 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
KUDU-2274. RaftConsensus should not access cmeta when shutdown
An additional case of KUDU-2274 found during stress testing was that
RaftConsensus will return a ConsensusStatePB from the ConsensusState()
RPC method even when shutdown. This patch prevents that.
Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Reviewed-on: http://gerrit.cloudera.org:8080/9266
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver_path_handlers.cc
11 files changed, 88 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9266/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9266/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@411
PS1, Line 411: ASSERT_OK(consensus->ConsensusState(&cs, RaftConsensus::INCLUDE_HEALTH_REPORT));
> It seems this assertion fails because it's not possible to fetch consensus
Ah. I'm planning on weakening this test in that case.
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 09 Feb 2018 19:52:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9266 )
Change subject: WIP: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9266/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9266/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@411
PS1, Line 411: ASSERT_OK(consensus->ConsensusState(&cs, RaftConsensus::INCLUDE_HEALTH_REPORT));
It seems this assertion fails because it's not possible to fetch consensus state from a failed replica:
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc:411: Failure
Failed
Bad status: Service unavailable: Tablet replica is shutdown
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/integration-tests/ts_tablet_manager-itest.cc:520: Failure
Expected: get_health_reports(&reports) doesn't generate new fatal failures in the current thread.
Actual: it does.
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/test_util.cc:291: Failure
Failed
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 18:28:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2274. RaftConsensus should not access cmeta when shutdown
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9266
to look at the new patch set (#3).
Change subject: KUDU-2274. RaftConsensus should not access cmeta when shutdown
......................................................................
KUDU-2274. RaftConsensus should not access cmeta when shutdown
An additional case of KUDU-2274 found during stress testing was that
RaftConsensus will return a ConsensusStatePB from the ConsensusState()
RPC method even when shutdown. This patch prevents that.
Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/tserver_path_handlers.cc
11 files changed, 89 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/9266/3
--
To view, visit http://gerrit.cloudera.org:8080/9266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib3f3f75674d5739b281e7c689ddb2d433b9b7415
Gerrit-Change-Number: 9266
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>