You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/22 18:24:52 UTC
[GitHub] [helix] narendly opened a new pull request #523: Add a null check
for StateModel in Participant reset logic
narendly opened a new pull request #523: Add a null check for StateModel in Participant reset logic
URL: https://github.com/apache/helix/pull/523
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #522
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
It was discovered that sometimes during shutdown/disconnect, this reset() gets called, and due to the partition having been dropped right around the same time, we get an NPE on the state model. Added a null check.
### Tests
- [ ] The following tests are written for this issue:
No test needed since it's a simple null check.
- [ ] The following is the result of the "mvn test" command on the appropriate module:
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org