[GitHub] adriancole commented on issue #1359: Run more tests in Zipkin examples

[GitBox <gi...@apache.org>]

adriancole commented on issue #1359: Run more tests in Zipkin examples
URL: https://github.com/apache/incubator-skywalking/issues/1359#issuecomment-398352687
 
 
   https://github.com/openzipkin?utf8=✓&q=example&type=&language= has a bunch
   of similar projects
   
   https://github.com/spring-cloud-samples/brewery is a more involved app
   
   also I think envoy has a zipkin example project.
   
   https://github.com/envoyproxy/envoy/tree/master/examples/zipkin-tracing
   
   On Sat, 16 Jun 2018, 20:26 吴晟 Wu Sheng, <no...@github.com> wrote:
   
   > In #1273 <https://github.com/apache/incubator-skywalking/pull/1273> , I
   > just test sleuth MVC example only. That is definitely not enough.
   >
   > @adriancole <https://github.com/adriancole> What other example projects
   > do you suggest to run by us? Could you put the repo URLs at here?
   >
   > And through these tests, maybe we could discuss more about other
   > suggestion/optional tags in Zipkin, which could help SkyWalking collectors
   > to run analysis better.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-skywalking/issues/1359>, or mute the
   > thread
   > <https://github.com/notifications/unsubscribe-auth/AAD61-ZlxggnoJa5wWMPOiLbR-Jqy2xfks5t9PmNgaJpZM4Uqd15>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services