[jira] [Commented] (NIFI-4698) Nifi Open ID Connect with Azure Active Directory fails to extract email from UserInfoToken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293376#comment-16293376 ] 

ASF GitHub Bot commented on NIFI-4698:
--------------------------------------

GitHub user rsomas opened a pull request:

    https://github.com/apache/nifi/pull/2346

    NIFI-4698 Extract upn if email is not in OpenID response Json

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ y] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ y] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ y] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ y] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsomas/nifi NIFI-4698

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2346
    
----
commit 363385df6f6a426bb2bf2494bb2adcd4a84e95e2
Author: Raghu Somasundaram <ra...@dvn.com>
Date:   2017-12-15T22:37:46Z

    NIFI-4698 Extract upn if email is not in OpenID response Json

----


> Nifi Open ID Connect with Azure Active Directory fails to extract email from UserInfoToken
> ------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4698
>                 URL: https://issues.apache.org/jira/browse/NIFI-4698
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.4.0
>         Environment: Microsoft Azure
>            Reporter: Raghu Somasundaram
>             Fix For: 1.5.0
>
>
> While integrating with Microsoft Azure Active Directory through OpenIDConnect, Azure AD sends back Json response without "email" attribute. This causes Nifi to throw following exception:
> 2017-12-12 16:34:20,442 ERROR [NiFi Web Server-67] org.apache.nifi.web.api.AccessResource Unable to exchange authorization for ID token: Unable to extract email from the UserInfo token.
> java.lang.IllegalStateException: Unable to extract email from the UserInfo token.
>         at org.apache.nifi.web.security.oidc.StandardOidcIdentityProvider.lookupEmail(StandardOidcIdentityProvider.java:352)
>         at org.apache.nifi.web.security.oidc.StandardOidcIdentityProvider.exchangeAuthorizationCode(StandardOidcIdentityProvider.java:306)
>         at org.apache.nifi.web.security.oidc.OidcService.exchangeAuthorizationCode(OidcService.java:192)
>         at org.apache.nifi.web.api.AccessResource.oidcCallback(AccessResource.java:256)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:167)
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
> The workaround is to extract "upn" attribute for email. This code fix checks the json response for "email" attribute. If email is empty, it returns "upn" value as email. If both email and upn are empty, we thrown the same exception as above.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)