You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/02/21 18:07:01 UTC
[GitHub] [drill] cgivre opened a new pull request #1992: DRILL-7596:
drill-format-esri module Uses Hard Coded Version Number
cgivre opened a new pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992
# [DRILL-7596](https://issues.apache.org/jira/browse/DRILL-7596): drill-format-esri module Uses Hard Coded Version Number
## Description
Removes hard coded version number from `format-esri`.
## Documentation
No user visible changes
## Testing
Ran unit tests associated with this format plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383257998
##########
File path: contrib/format-esri/pom.xml
##########
@@ -18,7 +18,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review comment:
Reverted first line spacing. Just as a side note, I ran Drill's code formatting macro in Intellij which did this. We might want to think about updating that so that this line is formatted correctly in future PRs, but that is out of scope for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383264281
##########
File path: contrib/format-esri/pom.xml
##########
@@ -18,7 +18,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review comment:
No worries. This kind of stuff is good for Drill. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383141391
##########
File path: contrib/format-esri/pom.xml
##########
@@ -72,7 +72,7 @@
<dependency>
<groupId>org.apache.drill.contrib</groupId>
<artifactId>drill-udfs</artifactId>
Review comment:
Is this dependency used in code, or it is required for tests only? If for tests, please specify the corresponding scope for it.
Also, please fix the alignment of `<dependencies>` block, it should be indented with two spaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383252197
##########
File path: contrib/format-esri/pom.xml
##########
@@ -18,7 +18,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review comment:
Please revert this change. `maven-release-plugin` automatically reformats the header line when `release:prepare` is performed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
cgivre commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383244373
##########
File path: contrib/format-esri/pom.xml
##########
@@ -72,7 +72,7 @@
<dependency>
<groupId>org.apache.drill.contrib</groupId>
<artifactId>drill-udfs</artifactId>
Review comment:
@vvysotskyi
Addressed review comments. This dependency is only required for a specific unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1992:
DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on a change in pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#discussion_r383263850
##########
File path: contrib/format-esri/pom.xml
##########
@@ -18,7 +18,8 @@
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Review comment:
I agree that our templates for both IDEA and Eclipse are a little bit outdated, but I believe they will be updated when we will add more checkstyle rules and reformat the project for them ([DRILL-7352](https://issues.apache.org/jira/browse/DRILL-7352)).
But for now, sorry for asking to do additional changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva merged pull request #1992: DRILL-7596:
drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva merged pull request #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #1992: DRILL-7596:
drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#issuecomment-591975671
@cgivre please rebase and squash the commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] cgivre commented on issue #1992: DRILL-7596:
drill-format-esri module Uses Hard Coded Version Number
Posted by GitBox <gi...@apache.org>.
cgivre commented on issue #1992: DRILL-7596: drill-format-esri module Uses Hard Coded Version Number
URL: https://github.com/apache/drill/pull/1992#issuecomment-591976879
Rebased and commits squashed. Thanks for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services