You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/18 21:33:49 UTC

[GitHub] [couchdb-nano] swansontec opened a new pull request #284: Properly escape partition ID's

swansontec opened a new pull request #284:
URL: https://github.com/apache/couchdb-nano/pull/284


   ## Overview
   
   This fixes issue #283, by running partition ID's through `encodeUriComponent`. This is consistent with the way Nano handles other things that may contain special characters, such as database ID's or document ID's.
   
   However, this is a breaking change, for reasons described in that bug report.
   
   ## Testing recommendations
   
   Try creating a partitioned database with partition ID's like `a+b` in Fauxton. If you invoke `db.partitionedList('a+b')` before this PR, you will get no results, but after this PR, it will work.
   
   ## GitHub issue number
   
   #283
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
   I can do steps 2 & 3 if there is interest in accepting this proposed change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird commented on pull request #284: Properly escape partition ID's

Posted by GitBox <gi...@apache.org>.
glynnbird commented on pull request #284:
URL: https://github.com/apache/couchdb-nano/pull/284#issuecomment-974204924


   Thanks for this @swansontec - I'll review next week


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #284: Properly escape partition ID's

Posted by GitBox <gi...@apache.org>.
glynnbird merged pull request #284:
URL: https://github.com/apache/couchdb-nano/pull/284


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org