You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by er...@apache.org on 2013/04/14 15:43:02 UTC

svn commit: r1467777 - /james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java

Author: eric
Date: Sun Apr 14 13:43:01 2013
New Revision: 1467777

URL: http://svn.apache.org/r1467777
Log:
Better protection against Denial-of-Service, patch contributed by Andrzej Rusin (JAMES-1427)

Modified:
    james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java

Modified: james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java
URL: http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java?rev=1467777&r1=1467776&r2=1467777&view=diff
==============================================================================
--- james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java (original)
+++ james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandler.java Sun Apr 14 13:43:01 2013
@@ -36,7 +36,7 @@ public class MaxUnknownCmdHandler implem
     public final static int DEFAULT_MAX_UNKOWN = 5;
     
     private final static String UNKOWN_COMMAND_COUNT = "UNKNOWN_COMMAND_COUNT";
-    private int maxUnknown;
+    private int maxUnknown = DEFAULT_MAX_UNKOWN;;
     
     public void setMaxUnknownCmdCount(int maxUnknown) {
         this.maxUnknown = maxUnknown;
@@ -55,7 +55,7 @@ public class MaxUnknownCmdHandler implem
         }
         session.setAttachment(UNKOWN_COMMAND_COUNT, count, State.Transaction);
         if (count > maxUnknown) {
-            return new HookResult(HookReturnCode.DENY | HookReturnCode.DISCONNECT, "521", "Closing connection as to many unknown commands received");
+            return new HookResult(HookReturnCode.DENY | HookReturnCode.DISCONNECT, "521", "Closing connection as too many unknown commands received");
 
         } else {
             



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org