You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 20:12:59 UTC
[GitHub] [spark] Kimahriman opened a new pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Kimahriman opened a new pull request #34246:
URL: https://github.com/apache/spark/pull/34246
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR adds array of struct support to unionByName. It further tries to simplify some of the logic for re-projecting different types by creating a `mergeFields` method that can find the right method to merge various combinations of fields, currently structs or arrays, but could add maps in the future.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently unionByName doesn't support arrays of structs or maps of structs. This adds support for the arrays of structs and should make it easy to add maps of structs support in the future.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
New capability to unionByName with arrays of structs.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-941799529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942896670
improvements are not generally backported. This is the general guidelines. Committers might decide to backport some improvement PRs if the risks look trivial or small but this does not often happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942896949
I think this kind of fix is clearly an improvement that affects behaviours so I won't backport either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-940603706
cc @viirya FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942884099
Could/should this and https://github.com/apache/spark/pull/34166 be backported now that the 3.2.0 release was cut?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942884706
For an improvement, we don't backport usually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-940603706
cc @viirya and @karenfeng FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942872689
Looks fine to me but would need a double check from @viirya who's more used to this code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-943276960
The lack of 3.1.0 release threw off my timeline for when the last minor release was and how much was included in patch releases, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-940409484
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727617264
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
* Resolves different children of Union to a common set of columns.
*/
object ResolveUnion extends Rule[LogicalPlan] {
+ /**
+ * Transform the array of structs to the target struct type.
Review comment:
Yeah I even made a test for that. It should handle infinite depth of any combination... theoretically. I can add a super convoluted test for something very nested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727617264
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
* Resolves different children of Union to a common set of columns.
*/
object ResolveUnion extends Rule[LogicalPlan] {
+ /**
+ * Transform the array of structs to the target struct type.
Review comment:
Yeah I even made a test for that. It should handle infinite depth of any combination... theoretically. I can add a super convoluted test for something very nested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-941806921
Updated the Dataset docs. Kinda reworded since unionByName works on nested columns now even without allowMissingColumns enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-941799529
> We may need to update API doc of `unionByName` in `Dataset` too.
Ah yep knew I forgot a comment to update somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya edited a comment on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942884706
For an improvement, we don't backport usually, IIRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942883080
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #34246:
URL: https://github.com/apache/spark/pull/34246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727612708
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
* Resolves different children of Union to a common set of columns.
*/
object ResolveUnion extends Rule[LogicalPlan] {
+ /**
+ * Transform the array of structs to the target struct type.
Review comment:
Can it be array of array of ... of struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34246:
URL: https://github.com/apache/spark/pull/34246#discussion_r727612708
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveUnion.scala
##########
@@ -32,13 +32,28 @@ import org.apache.spark.sql.util.SchemaUtils
* Resolves different children of Union to a common set of columns.
*/
object ResolveUnion extends Rule[LogicalPlan] {
+ /**
+ * Transform the array of structs to the target struct type.
Review comment:
Can it be array of array of ... of struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #34246: [SPARK-36546][SQL] Add array support to union by name
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #34246:
URL: https://github.com/apache/spark/pull/34246#issuecomment-942893524
I was thinking only major new features weren't backported vs incremental improvements on existing features. And what about perf only improvements like https://github.com/apache/spark/pull/34166?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org