You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/24 06:04:37 UTC
[GitHub] [shardingsphere] Pace2Car opened a new pull request, #22378: Improve DistSQL DROP ENCRYPT RULE
Pace2Car opened a new pull request, #22378:
URL: https://github.com/apache/shardingsphere/pull/22378
For #22358 .
Changes proposed in this pull request:
- Improve DROP ENCRYPT RULE, remove unused algorithms while dropping rule
- Supplementary related test cases
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22378: Improve DistSQL DROP ENCRYPT RULE
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378#issuecomment-1326019685
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22378](https://codecov.io/gh/apache/shardingsphere/pull/22378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d9866a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7ea19c74b82fddb908b00199dbb424a41d05e89f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ea19c7) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #22378 +/- ##
=========================================
Coverage 51.02% 51.03%
+ Complexity 2499 2498 -1
=========================================
Files 4167 4166 -1
Lines 57815 57824 +9
Branches 9820 9818 -2
=========================================
+ Hits 29501 29508 +7
- Misses 25785 25787 +2
Partials 2529 2529
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sserts/statement/dml/impl/CallStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kbWwvaW1wbC9DYWxsU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...andler/update/DropEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRW5jcnlwdFJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `79.31% <100.00%> (+5.97%)` | :arrow_up: |
| [...er/domain/statement/dml/CallStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/22378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9jYXNlcy9wYXJzZXIvZG9tYWluL3N0YXRlbWVudC9kbWwvQ2FsbFN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...ate/DropDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/22378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRGF0YWJhc2VEaXNjb3ZlcnlSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `87.50% <0.00%> (+1.01%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve DistSQL DROP ENCRYPT RULE [shardingsphere]
Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378#issuecomment-1878390391
> still wrong logic about DROP ENCRYPT RULE in 5.4.1, what's your logic about: rules.removeIf(each -> each.getConfiguration().getClass().isAssignableFrom(ruleConfig.getClass())); It delete all encrypt rule
Thanks for the feedback, all database rule will be rebuilt based on the remaining configuration after cleaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22378: Improve DistSQL DROP ENCRYPT RULE
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Pace2Car commented on pull request #22378: Improve DistSQL DROP ENCRYPT RULE
Posted by GitBox <gi...@apache.org>.
Pace2Car commented on PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378#issuecomment-1325997252
please add lables: `feature: DistSQL` `feature: encrypt` `type: enhancement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve DistSQL DROP ENCRYPT RULE [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378#issuecomment-1868315609
@hhw3KevinHou Thanks for the feedback!
Hi, @Pace2Car can you check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve DistSQL DROP ENCRYPT RULE [shardingsphere]
Posted by "hhw3KevinHou (via GitHub)" <gi...@apache.org>.
hhw3KevinHou commented on PR #22378:
URL: https://github.com/apache/shardingsphere/pull/22378#issuecomment-1867451898
still wrong logic about DROP ENCRYPT RULE in 5.4.1, what's your logic about:
rules.removeIf(each -> each.getConfiguration().getClass().isAssignableFrom(ruleConfig.getClass()));
It delete all encrypt rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org