You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Bill Havanki <bh...@clouderagovt.com> on 2014/01/14 15:09:49 UTC
Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/
-----------------------------------------------------------
Review request for accumulo and Josh Elser.
Bugs: ACCUMULO-2182
https://issues.apache.org/jira/browse/ACCUMULO-2182
Repository: accumulo
Description
-------
Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
Diffs
-----
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
Diff: https://reviews.apache.org/r/16857/diff/
Testing
-------
Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
Thanks,
Bill Havanki
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Jan. 14, 2014, 1:12 p.m., Josh Elser wrote:
> > Since you didn't use cherry-pick, I expect that you took the time to ensure that you pulled back the changes from the commits for each issue. Also, please be sure to add something to the commit message that outlines that "these changes are a backport from blah blah blah", or similar.
Yes, I had to be especially careful since the test code was re-jiggered from 1.4.x to 1.5.x, especially in going from SecurityHelper (1.4) to WalkingSecurity (1.5). Hence why I wanted more eyes on it.
I'm going to have one commit per backport, and the messages will look like you suggest. Thanks!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31742
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31742
-----------------------------------------------------------
Ship it!
Since you didn't use cherry-pick, I expect that you took the time to ensure that you pulled back the changes from the commits for each issue. Also, please be sure to add something to the commit message that outlines that "these changes are a backport from blah blah blah", or similar.
- Josh Elser
On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:09 p.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Mike Drob <md...@mdrob.com>.
> On Jan. 14, 2014, 6:11 p.m., Josh Elser wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java, line 101
> > <https://reviews.apache.org/r/16857/diff/1/?file=422676#file422676line101>
> >
> > The blind 1 second sleep still seems error prone to me, but, like Mike pointed out, it's just a backport of what's upstream.
>
> Bill Havanki wrote:
> Before discovering ACCUMULO-1123, I had put in a sleep myself, but at least made the duration a XML configuration property for the node in the walk. Adding that configurability here (and in CreateUser) could be a new JIRA.
>
> In the end, I think the "right" answer is that there should be a password change call that only returns once the change is guaranteed to be in effect.
ACCUMULO-2200
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31740
-----------------------------------------------------------
On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:09 p.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Jan. 14, 2014, 1:11 p.m., Josh Elser wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java, line 101
> > <https://reviews.apache.org/r/16857/diff/1/?file=422676#file422676line101>
> >
> > The blind 1 second sleep still seems error prone to me, but, like Mike pointed out, it's just a backport of what's upstream.
Before discovering ACCUMULO-1123, I had put in a sleep myself, but at least made the duration a XML configuration property for the node in the walk. Adding that configurability here (and in CreateUser) could be a new JIRA.
In the end, I think the "right" answer is that there should be a password change call that only returns once the change is guaranteed to be in effect.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31740
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Jan. 14, 2014, 1:11 p.m., Josh Elser wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java, line 101
> > <https://reviews.apache.org/r/16857/diff/1/?file=422676#file422676line101>
> >
> > The blind 1 second sleep still seems error prone to me, but, like Mike pointed out, it's just a backport of what's upstream.
>
> Bill Havanki wrote:
> Before discovering ACCUMULO-1123, I had put in a sleep myself, but at least made the duration a XML configuration property for the node in the walk. Adding that configurability here (and in CreateUser) could be a new JIRA.
>
> In the end, I think the "right" answer is that there should be a password change call that only returns once the change is guaranteed to be in effect.
>
> Mike Drob wrote:
> ACCUMULO-2200
Thanks Mike.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31740
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31740
-----------------------------------------------------------
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java
<https://reviews.apache.org/r/16857/#comment60466>
The blind 1 second sleep still seems error prone to me, but, like Mike pointed out, it's just a backport of what's upstream.
- Josh Elser
On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:09 p.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Jan. 14, 2014, 12:51 p.m., Mike Drob wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java, line 123
> > <https://reviews.apache.org/r/16857/diff/1/?file=422673#file422673line123>
> >
> > It looks like there is a potential concurrency issue between this method and isMultiTableBatchWriterInitialized, but I haven't traced deep enough to discover if that's a real problem for us or not. Also, the issue exists upstream, so this is a faithful backport, if nothing else. Maybe it makes sense to open a new JIRA for the bug.
New JIRA sounds good to me.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31737
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On Jan. 14, 2014, 12:51 p.m., Mike Drob wrote:
> > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java, line 123
> > <https://reviews.apache.org/r/16857/diff/1/?file=422673#file422673line123>
> >
> > It looks like there is a potential concurrency issue between this method and isMultiTableBatchWriterInitialized, but I haven't traced deep enough to discover if that's a real problem for us or not. Also, the issue exists upstream, so this is a faithful backport, if nothing else. Maybe it makes sense to open a new JIRA for the bug.
>
> Bill Havanki wrote:
> New JIRA sounds good to me.
https://issues.apache.org/jira/browse/ACCUMULO-2193
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31737
-----------------------------------------------------------
On Jan. 14, 2014, 9:09 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 9:09 a.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
1.4.5-SNAPSHOT
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31737
-----------------------------------------------------------
Ship it!
src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java
<https://reviews.apache.org/r/16857/#comment60465>
It looks like there is a potential concurrency issue between this method and isMultiTableBatchWriterInitialized, but I haven't traced deep enough to discover if that's a real problem for us or not. Also, the issue exists upstream, so this is a faithful backport, if nothing else. Maybe it makes sense to open a new JIRA for the bug.
- Mike Drob
On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 2:09 p.m.)
>
>
> Review request for accumulo and Josh Elser.
>
>
> Bugs: ACCUMULO-2182
> https://issues.apache.org/jira/browse/ACCUMULO-2182
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
>
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
>
>
> Diffs
> -----
>
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893
> src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c
>
> Diff: https://reviews.apache.org/r/16857/diff/
>
>
> Testing
> -------
>
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
>
>
> Thanks,
>
> Bill Havanki
>
>