You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/09 02:58:52 UTC
[GitHub] [camel] cunningt opened a new pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
cunningt opened a new pull request #6518:
URL: https://github.com/apache/camel/pull/6518
Giving the changes from https://github.com/apache/camel/pull/6462 another try. The properties in camel-dependencies are synced from camel-parent within camel-catalog, but there is not a guarantee that the sync will happen because of how maven determines the build order. I don't believe that the module order change here https://github.com/apache/camel/commit/71e28ebe69a5c87721bbc63693a884473baf302e#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 fixes the issue - maven's reactor determines the correct build order and factors in the dependencies of the modules (https://maven.apache.org/guides/mini/guide-multiple-modules.html). camel-dependencies has no dependencies currently, so from what I've seen in building the project, the reactor views it as a good candidate to run early, despite the module ordering.
Moved the sync out of camel-catalog and into to camel-dependencies, which generates the camel-dependencies pom. The change to SyncPropertiesMojo attaches the camel-dependencies artifact to the build so that it can be consumed by the downstream projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-998220044
Oh did we not merge this, now we have merge conflicts again. @cunningt wonder if you can rebase yet again (sorry)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] cunningt commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
cunningt commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-998409996
No worries, did another rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-996455637
@cunningt we have moved to 3.15, can you rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-993479586
We'll need to rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] cunningt commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
cunningt commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-993482400
Sounds good to me - I'll rebase after the move to 3.15.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] cunningt commented on pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
cunningt commented on pull request #6518:
URL: https://github.com/apache/camel/pull/6518#issuecomment-997212747
Rebased on top of current main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6518: CAMEL-17062 Move properties sync to camel-dependencies to avoid deployment issues
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6518:
URL: https://github.com/apache/camel/pull/6518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org