You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Aaron Gooch <eo...@gmail.com> on 2012/12/03 14:33:50 UTC
Review Request: RAVE-847 bug fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8318/
-----------------------------------------------------------
Review request for rave.
Description
-------
Small change to base_layout.jsp. Load custom.js files after loading rave.
This addresses bug RAVE-847.
https://issues.apache.org/jira/browse/RAVE-847
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1415304
Diff: https://reviews.apache.org/r/8318/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-847 bug fix
Posted by Matt Franklin <mf...@apache.org>.
> On Dec. 5, 2012, 2:13 p.m., Matt Franklin wrote:
> > Ship It!
Committed r1417663
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8318/#review14050
-----------------------------------------------------------
On Dec. 3, 2012, 1:33 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8318/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 1:33 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Small change to base_layout.jsp. Load custom.js files after loading rave.
>
>
> This addresses bug RAVE-847.
> https://issues.apache.org/jira/browse/RAVE-847
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1415304
>
> Diff: https://reviews.apache.org/r/8318/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-847 bug fix
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8318/#review14050
-----------------------------------------------------------
Ship it!
Ship It!
- Matt Franklin
On Dec. 3, 2012, 1:33 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8318/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 1:33 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> Small change to base_layout.jsp. Load custom.js files after loading rave.
>
>
> This addresses bug RAVE-847.
> https://issues.apache.org/jira/browse/RAVE-847
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1415304
>
> Diff: https://reviews.apache.org/r/8318/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>