[GitHub] [pulsar] ivankelly commented on a change in pull request #4329: Moved entries filtering from consumer to dispatcher

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #4329: Moved entries filtering from consumer to dispatcher
URL: https://github.com/apache/pulsar/pull/4329#discussion_r286189955
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
 ##########
 @@ -190,55 +181,32 @@ public boolean readCompacted() {
      *
      * @return a SendMessageInfo object that contains the detail of what was sent to consumer
      */
-    public SendMessageInfo sendMessages(final List<Entry> entries) {
-        // Empty listener
-        return sendMessages(entries, null);
-    }
-
-    /**
-     * Dispatch a list of entries to the consumer. <br/>
-     * <b>It is also responsible to release entries data and recycle entries object.</b>
-     *
-     * @return a SendMessageInfo object that contains the detail of what was sent to consumer
-     */
-    public SendMessageInfo sendMessages(final List<Entry> entries, SendListener listener) {
+    public ChannelPromise sendMessages(final List<Entry> entries, int[] batchSizes, SendMessageInfo sendMessageInfo) {
 
 Review comment:
   maybe rename batchSizes to threadLocalBatchSizes and same for sendMessageInfo to give a hint for future users that they can't move off the thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services