You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2016/04/11 14:35:01 UTC

Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.


Bugs: RANGER-913
    https://issues.apache.org/jira/browse/RANGER-913


Repository: ranger


Description
-------

** PROBLEM STATEMENT ** 
Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
Also include ability to download the report to a Excel.

** PROPOSED SOLUTION ** 

1) Added Resources and permissions in searched list of policies table. 
2) Added feature of download Excel in reports.
3) Allowing to search policies for selected component.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
  pom.xml c21299d 
  security-admin/pom.xml b9590bf 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
  security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
  security-admin/src/main/webapp/styles/xa.css 331cda1 
  security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 

Diff: https://reviews.apache.org/r/46019/diff/


Testing
-------

Verified : Search result of policies based on below given criterias.

1) Search by User 
2) Search By Group
3) Search by multiple service types 
4) Verified combinations of these and also checked download Excel feature based on search.


Thanks,

Mehul Parikh

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review129029
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On April 14, 2016, 8:51 a.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:51 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml 03815c1 
>   security-admin/pom.xml 5e03564 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Mehul Parikh <me...@freestoneinfotech.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/
-----------------------------------------------------------

(Updated April 14, 2016, 8:51 a.m.)


Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.


Changes
-------

Handled comments by Gautam and Tushar.


Bugs: RANGER-913
    https://issues.apache.org/jira/browse/RANGER-913


Repository: ranger


Description
-------

** PROBLEM STATEMENT ** 
Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
Also include ability to download the report to a Excel.

** PROPOSED SOLUTION ** 

1) Added Resources and permissions in searched list of policies table. 
2) Added feature of download Excel in reports.
3) Allowing to search policies for selected component.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
  pom.xml 03815c1 
  security-admin/pom.xml 5e03564 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
  security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
  security-admin/src/main/webapp/styles/xa.css 331cda1 
  security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 

Diff: https://reviews.apache.org/r/46019/diff/


Testing
-------

Verified : Search result of policies based on below given criterias.

1) Search by User 
2) Search By Group
3) Search by multiple service types 
4) Verified combinations of these and also checked download Excel feature based on search.


Thanks,

Mehul Parikh

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Tushar Dudhatra <tu...@gmail.com>.


> On April 12, 2016, 5:24 a.m., Tushar Dudhatra wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java, line 138
> > <https://reviews.apache.org/r/46019/diff/1/?file=1339199#file1339199line138>
> >
> >     Rather querying for only groupId, querying for XXGroup and iterating over List<XXGroup> will be helpful because anyways at line no. #141 XXGroup object is required so that database call at #141 is avoidable.
> 
> Pradeep Agrawal wrote:
>     @Tushar : Currently there is no method available in XXGroupUserDao class which can give list of XXGroup object based on provided user_id, however it seems only group name is required so 'daoMgr.getXXGroupUser().findGroupNamesByUserName(userName)' can be called before loop and iteration can be done on received set object as return type of mentioned method is 'Set<String>'. Please review.

@Pradeep: Agreed, that is the right way to go with.


- Tushar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128335
-----------------------------------------------------------


On April 11, 2016, 12:35 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:35 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml c21299d 
>   security-admin/pom.xml b9590bf 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.


> On April 12, 2016, 5:24 a.m., Tushar Dudhatra wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java, line 138
> > <https://reviews.apache.org/r/46019/diff/1/?file=1339199#file1339199line138>
> >
> >     Rather querying for only groupId, querying for XXGroup and iterating over List<XXGroup> will be helpful because anyways at line no. #141 XXGroup object is required so that database call at #141 is avoidable.

@Tushar : Currently there is no method available in XXGroupUserDao class which can give list of XXGroup object based on provided user_id, however it seems only group name is required so 'daoMgr.getXXGroupUser().findGroupNamesByUserName(userName)' can be called before loop and iteration can be done on received set object as return type of mentioned method is 'Set<String>'. Please review.


- Pradeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128335
-----------------------------------------------------------


On April 11, 2016, 12:35 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:35 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml c21299d 
>   security-admin/pom.xml b9590bf 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Mehul Parikh <me...@freestoneinfotech.com>.


> On April 12, 2016, 5:24 a.m., Tushar Dudhatra wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java, line 1830
> > <https://reviews.apache.org/r/46019/diff/1/?file=1339197#file1339197line1830>
> >
> >     If user wants to download policies for 10 services then this logic will goto database 10 times to find policies for each service. Rather this, can't we get all the policies of all given services with one database call ? 
> >     Just concern about the performance.

Implementation will not make DB calls for each service, instead it will make DB call for each serviceType. So if we have 10 services in HDFS and 10  services in HIVE, still it will make only 2 DB calls, one for HDFS and one for HIVE. 

For readability, I have replaced the variable name from services to serviceTypeNames.


- Mehul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128335
-----------------------------------------------------------


On April 14, 2016, 8:51 a.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 8:51 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml 03815c1 
>   security-admin/pom.xml 5e03564 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Tushar Dudhatra <tu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128335
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1825)
<https://reviews.apache.org/r/46019/#comment191761>

    If user wants to download policies for 10 services then this logic will goto database 10 times to find policies for each service. Rather this, can't we get all the policies of all given services with one database call ? 
    Just concern about the performance.



security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1872)
<https://reviews.apache.org/r/46019/#comment191762>

    Just a minor correction, arrow pointing in wrong direction: LOG.debug("==> ServiceDBStore.getPoliciesInExcel()")



security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java (line 137)
<https://reviews.apache.org/r/46019/#comment191763>

    This will throw NPE at this line if `xuser` is null. Also just to maintain consistensy if we can use camelCase naming convention, it will be good. user_id --> userId



security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java (line 138)
<https://reviews.apache.org/r/46019/#comment191764>

    Rather querying for only groupId, querying for XXGroup and iterating over List<XXGroup> will be helpful because anyways at line no. #141 XXGroup object is required so that database call at #141 is avoidable.


- Tushar Dudhatra


On April 11, 2016, 12:35 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:35 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml c21299d 
>   security-admin/pom.xml b9590bf 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Gautam Borad <gb...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128329
-----------------------------------------------------------




security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js (line 105)
<https://reviews.apache.org/r/46019/#comment191756>

    Please consider changing the name to be more descriptive.


- Gautam Borad


On April 11, 2016, 12:35 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:35 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml c21299d 
>   security-admin/pom.xml b9590bf 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>

Re: Review Request 46019: RANGER-913 : Improvements on Reports page in Ranger Admin

Posted by Gautam Borad <gb...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46019/#review128108
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1874)
<https://reviews.apache.org/r/46019/#comment191490>

    Can we make this configurable?
    At the very list we should put a timestamp in the file name.


- Gautam Borad


On April 11, 2016, 12:35 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46019/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 12:35 p.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-913
>     https://issues.apache.org/jira/browse/RANGER-913
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** PROBLEM STATEMENT ** 
> Improve current reporting to provide a functionality for user to get access to a given resource or set of resources across Hadoop (resource could include tags as well)
> Also include ability to download the report to a Excel.
> 
> ** PROPOSED SOLUTION ** 
> 
> 1) Added Resources and permissions in searched list of policies table. 
> 2) Added feature of download Excel in reports.
> 3) Allowing to search policies for selected component.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 61e8b09 
>   pom.xml c21299d 
>   security-admin/pom.xml b9590bf 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 9d2e4c6 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 8f01bfc 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 4929cf6 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 6611fa6 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 47177f4 
>   security-admin/src/main/webapp/styles/xa.css 331cda1 
>   security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 1352882 
> 
> Diff: https://reviews.apache.org/r/46019/diff/
> 
> 
> Testing
> -------
> 
> Verified : Search result of policies based on below given criterias.
> 
> 1) Search by User 
> 2) Search By Group
> 3) Search by multiple service types 
> 4) Verified combinations of these and also checked download Excel feature based on search.
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>