[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #1274: IGNITE-17754 Print API endpoint address on node start

[GitBox <gi...@apache.org>]

ptupitsyn commented on code in PR #1274:
URL: https://github.com/apache/ignite-3/pull/1274#discussion_r1031231236


##########
packaging/zip/ignite3db:
##########
@@ -33,12 +32,21 @@ if [ -z ${IGNITE_HOME+x} ]; then IGNITE_HOME=$(pwd); fi
 cd ${IGNITE_HOME} || exit
 
 start() {
+  echo "Starting Ignite 3..."
+
   CMD="${JAVA_CMD_WITH_ARGS} ${APPLICATION_ARGS}"
   $CMD >>/dev/null 2>&1 </dev/null & echo $! >${IGNITE_HOME}/pid
+
+  rest_address_file=${WORK_DIR}/rest-address
+  while [ ! -f "$rest_address_file" ]; do sleep 0.5; done
+    rest_address=$(cat "$rest_address_file")
+
+  echo "Node named ${NODE_NAME} started successfully. REST address is http://$rest_address"

Review Comment:
   To clarify, I think we have 3 kinds of APIs
   * REST
   * JDBC
   * General purpose clients
   
   Let's print endpoint addresses for all of them.
   
   JDBC and regular clients use the same endpoint, but it makes sense to print JDBC connection string separately for easy copy/paste. You can get the address from `ClientHandlerModule.localAddress()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org